From: Brice Waegeneire <brice@waegenei.re>
To: maximedevos@telenet.be
Cc: 53953@debbugs.gnu.org
Subject: [bug#53953] [PATCH v2] gnu: Add acpilight.
Date: Sat, 12 Feb 2022 18:21:25 +0100 [thread overview]
Message-ID: <20220212172125.3648-1-brice@waegenei.re> (raw)
In-Reply-To: <20220212104432.22611-1-brice@waegenei.re>
* gnu/packages/linux.scm (acpilight): New variable.
---
Maxime,
Thanks for the review. I should have re-read this old package more throughly,
I have fixed what you pointed out:
- using gexp in arguments field
- don't returning #t in phases
- adding coreutils-minimal to inputs
As for the odd make-flags, this is because of the uncanonical Makefile¹ of
acpilight, It don't build with an empty DESTDIR.
¹ https://gitlab.com/wavexx/acpilight/-/blob/master/Makefile
Cheers,
- Brice
gnu/packages/linux.scm | 40 +++++++++++++++++++++++++++++++++++++++-
1 file changed, 39 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index bcbaa2166d..fe88d9ad26 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -35,7 +35,7 @@
;;; Copyright © 2019 Tim Gesthuizen <tim.gesthuizen@yahoo.de>
;;; Copyright © 2019, 2020, 2021 Maxim Cournoyer <maxim.cournoyer@gmail.com>
;;; Copyright © 2019 Stefan Stefanović <stefanx2ovic@gmail.com>
-;;; Copyright © 2019, 2020, 2021 Brice Waegeneire <brice@waegenei.re>
+;;; Copyright © 2019-2022 Brice Waegeneire <brice@waegenei.re>
;;; Copyright © 2019 Kei Kebreau <kkebreau@posteo.net>
;;; Copyright © 2020, 2021 Oleg Pykhalov <go.wigust@gmail.com>
;;; Copyright © 2020 Pierre Neidhardt <mail@ambrevar.xyz>
@@ -8806,3 +8806,41 @@ (define-public libgpiod
(license (list license:lgpl2.1+ ;; libgpiod
license:gpl2+ ;; gpio-tools
license:lgpl3+)))) ;; C++ bindings
+
+(define-public acpilight
+ (package
+ (name "acpilight")
+ (version "1.2")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://gitlab.com/wavexx/acpilight.git")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1r0r3nx6x6vkpal6vci0zaa1n9dfacypldf6k8fxg7919vzxdn1w"))))
+ (build-system gnu-build-system)
+ (arguments
+ (list #:tests? #f ;no tests
+ #:make-flags #~(list "prefix="
+ (string-append "DESTDIR=" #$output))
+ #:phases
+ #~(modify-phases %standard-phases
+ (delete 'configure)
+ (add-after 'unpack 'patch
+ (lambda* (#:key inputs #:allow-other-keys)
+ (substitute* "Makefile"
+ (("udevadm") "true"))
+ (substitute* "90-backlight.rules"
+ (("/bin")
+ (string-append (assoc-ref inputs "coreutils-minimal") "/bin"))))))))
+ (inputs
+ (list python coreutils-minimal))
+ (home-page "https://gitlab.com/wavexx/acpilight")
+ (synopsis "Backward-compatibile xbacklight replacement")
+ (description "acpilight is a backward-compatibile replacement for
+xbacklight that uses the ACPI interface to set the display
+brightness. On modern laptops acpilight can control both display and
+keyboard backlight uniformly on either X11, the console or Wayland.")
+ (license license:gpl3+)))
base-commit: e641d707e1ec8de2bfc658dcd1757360300aa509
--
2.34.0
next prev parent reply other threads:[~2022-02-12 17:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-12 10:44 [bug#53953] [PATCH] gnu: Add acpilight Brice Waegeneire
2022-02-12 13:34 ` Maxime Devos
2022-02-12 13:38 ` Maxime Devos
2022-02-12 17:21 ` Brice Waegeneire [this message]
2022-02-12 18:05 ` [bug#53953] [PATCH v2] " Maxime Devos
2022-02-16 7:22 ` [bug#53953] [PATCH v3] " Brice Waegeneire
2022-03-06 21:17 ` [bug#53953] [PATCH] " Ludovic Courtès
2022-04-05 16:06 ` Ludovic Courtès
2022-09-28 19:57 ` bug#53953: " Maxim Cournoyer
2022-06-01 14:14 ` [bug#53953] " Antero Mejr via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220212172125.3648-1-brice@waegenei.re \
--to=brice@waegenei.re \
--cc=53953@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.