From: "Ludovic Courtès" <ludo@gnu.org>
To: 53608@debbugs.gnu.org
Cc: "Ludovic Courtès" <ludo@gnu.org>,
"Maxime Devos" <maximedevos@telenet.be>,
"Attila Lendvai" <attila@lendvai.name>
Subject: [bug#53608] [PATCH 0/2] Rejecting commits unrelated to the introductory commit
Date: Fri, 28 Jan 2022 18:31:42 +0100 [thread overview]
Message-ID: <20220128173142.7072-1-ludo@gnu.org> (raw)
Hello!
This patch series fixes a bug in the checkout authentication code:
it would be possible to authenticate a commit unrelated to the
introductory commit, provided that target commit passes the
authorization invariant (see the commit log for details).
Users of Guix and of third-party channels are safe: this bug does
not have any impact on checkout authentication in those cases.
What concrete cases are affected? Suppose someone forks Guix and
publishes a new channel introduction for their fork. The expectation
is that any branch started before the introductory channel, for
instance in the original Guix repo, would fail to be authenticated.
However, because of this bug, such a branch would be considered
authentic in the fork because all its commits pass the authorization
invariant (IOW, they are authentic in the original repository).
Thoughts?
Ludo'.
Ludovic Courtès (2):
git: Add 'commit-descendant?'.
git-authenticate: Ensure the target is a descendant of the
introductory commit.
doc/guix.texi | 4 ++-
guix/git-authenticate.scm | 17 ++++++++--
guix/git.scm | 24 +++++++++++++-
tests/channels.scm | 60 +++++++++++++++++++++++++++++++++-
tests/git-authenticate.scm | 44 +++++++++++++++++++++++++
tests/git.scm | 52 ++++++++++++++++++++++++++++-
tests/guix-git-authenticate.sh | 17 ++++++++--
7 files changed, 210 insertions(+), 8 deletions(-)
base-commit: 5052f76afd02e27d6484acf74c86bfa1b6f9cd0e
--
2.34.0
next reply other threads:[~2022-01-28 17:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 17:31 Ludovic Courtès [this message]
2022-01-28 17:43 ` [bug#53608] [PATCH 1/2] git: Add 'commit-descendant?' Ludovic Courtès
2022-01-28 17:43 ` [bug#53608] [PATCH 2/2] git-authenticate: Ensure the target is a descendant of the introductory commit Ludovic Courtès
2022-02-08 23:02 ` [bug#53608] [PATCH 0/2] Rejecting commits unrelated to " Ludovic Courtès
2022-02-10 22:29 ` Maxime Devos
2022-02-14 10:33 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220128173142.7072-1-ludo@gnu.org \
--to=ludo@gnu.org \
--cc=53608@debbugs.gnu.org \
--cc=attila@lendvai.name \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.