From: Thiago Jung Bauermann via Guix-patches via <guix-patches@gnu.org>
To: 51467@debbugs.gnu.org
Cc: Thiago Jung Bauermann <bauermann@kolabnow.com>
Subject: [bug#51467] [PATCH core-updates-frozen] gnu: gtk+: Fix testsuite failure on non-x86_64 platforms.
Date: Thu, 28 Oct 2021 16:43:23 -0300 [thread overview]
Message-ID: <20211028194323.50370-1-bauermann@kolabnow.com> (raw)
On non-x86_64 platforms, gtk+ is linked with a gdk-pixbuf version that
doesn’t support SVG. This causes the ‘tree-relationships’ test to fail
because it tries to fetch SVG icons in some of the tests.
Therefore, we need to disable the test when SVG support isn’t available.
* gnu/packages/gtk.scm (gtk+)[arguments]<#:phases>{disable-failing-tests}:
Disable ‘tree-relationships’ test on non-x86_64 platforms.
---
Hello,
Considering that the core-updates-frozen-batched-changes branch will
soon make GTK+ depend on Rust (via an updated mozjs package), perhaps
this patch is somewhat pointless. But I thought it would be at least a
bit useful to have this information recorded.
Also, there's a good change that polkit will switch from mozjs to duktape
as its Javascript engine. In that case it will be useful again to have
this patch in.
With this patch, GTK+ builds again on core-updates-frozen on
powerpc64le-linux. This patch doesn't change the package derivation
on x86_64-linux
Thanks,
Thiago.
gnu/packages/gtk.scm | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index fadd0794c5dd..40fc2c93d681 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -1106,7 +1106,12 @@ (define-public gtk+
'()))
(substitute* "testsuite/a11y/Makefile.in"
(("accessibility-dump tree-performance text children derive")
- "tree-performance text children derive"))
+ "tree-performance text children derive")
+ ;; The ‘tree-relationships’ test needs SVG support.
+ ,@(if (not (target-x86-64?))
+ '((("value misc tree-relationships util")
+ "value misc util"))
+ '()))
(substitute* "testsuite/reftests/Makefile.in"
(("TEST_PROGS = gtk-reftest")
"TEST_PROGS = "))
next reply other threads:[~2021-10-28 19:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 19:43 Thiago Jung Bauermann via Guix-patches via [this message]
2021-11-12 6:05 ` bug#51467: [PATCH core-updates-frozen] gnu: gtk+: Fix testsuite failure on non-x86_64 platforms Maxim Cournoyer
[not found] ` <2566471.izIe66Ckzq@popigai>
2021-11-17 0:56 ` Thiago Jung Bauermann via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211028194323.50370-1-bauermann@kolabnow.com \
--to=guix-patches@gnu.org \
--cc=51467@debbugs.gnu.org \
--cc=bauermann@kolabnow.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.