all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ryan Sundberg via Guix-patches via <guix-patches@gnu.org>
To: 49766@debbugs.gnu.org
Cc: Ryan Sundberg <ryan@arctype.co>
Subject: [bug#49766] [PATCH] gnu: rocksdb: set TEST_TMPDIR for faster test i/o.
Date: Wed, 28 Jul 2021 22:00:26 -0700	[thread overview]
Message-ID: <20210729050026.18416-1-ryan@arctype.co> (raw)

The rocksdb test can take an egregious amount of time on a spinning HDD.
This will inherit guixbuild's /tmp mount for the rocksdb testing
directory.

* gnu/packages/databases.scm (rocksdb)[arguments]: set TEST_TMPDIR for
check phase
---
 gnu/packages/databases.scm | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index 5de79de955..cd19d14950 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -1395,10 +1395,19 @@ including field and record folding.")))
                (("install: install-static")
                 "install: install-shared")
                (("#!/bin/sh") (string-append "#!" (which "sh"))))
-             #t))
+             #t)) 
          (delete 'configure)
          ;; The default target is only needed for tests and built on demand.
          (delete 'build)
+         (add-before 'check 'mount-tmp
+           ;; Use the provided workspace directory for test files.
+           ;; Otherwise, /tmp is used which is a mount namespace on /gnu/store.
+           ;; This speeds up the build when the host /tmp is a proper tmpfs or
+           ;; other fast filesystem, as opposed to /gnu which may be a HDD.
+           (lambda _
+             (let ((test-dir (string-append (getcwd) "/../test")))
+               (mkdir test-dir)
+               (setenv "TEST_TMPDIR" (canonicalize-path test-dir)))))
          (add-before 'check 'disable-optimizations
            (lambda _
              ;; Prevent the build from passing '-march=native' to the compiler.
@@ -1429,6 +1438,7 @@ including field and record folding.")))
        ("perl" ,perl)
        ("procps" ,procps)
        ("python" ,python-2)
+       ("util-linux" ,util-linux)
        ("which" ,which)))
     (inputs
      `(("bzip2" ,bzip2)
-- 
2.31.1





             reply	other threads:[~2021-07-29  5:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29  5:00 Ryan Sundberg via Guix-patches via [this message]
2021-07-29  5:08 ` [bug#49766] [PATCH] gnu: rocksdb: set TEST_TMPDIR for faster test i/o Ryan Sundberg via Guix-patches via
2021-07-29  5:13 ` Ryan Sundberg via Guix-patches via
2021-07-29  5:17   ` Ryan Sundberg via Guix-patches via
2021-08-10 15:13     ` bug#49766: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210729050026.18416-1-ryan@arctype.co \
    --to=guix-patches@gnu.org \
    --cc=49766@debbugs.gnu.org \
    --cc=ryan@arctype.co \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.