From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: 49227@debbugs.gnu.org
Cc: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: [bug#49227] [PATCH 0/3] Some Qt/qtbase improvements.
Date: Fri, 25 Jun 2021 14:04:14 -0400 [thread overview]
Message-ID: <20210625180414.10045-1-maxim.cournoyer@gmail.com> (raw)
Hello Guix!
The following 3 patches are some minor improvements for Qt in Guix. They
allow them to use GTK themes, which noticeably improve the look of things such
as the file picker on systems using a GTK theme. Passing the configure flags
via the #:configure-flags argument for qtbase allows package rewriting, for
example, building a static version of it:
--8<---------------cut here---------------start------------->8---
(use-modules (gnu packages qt)
(guix packages)
(guix transformations)
(guix utils))
;;; Adapted from static-package in (guix build-system gnu).
(define* (static-package-qt p #:key (strip-all? #t))
"Return a statically-linked version of package P. If STRIP-ALL? is true,
use `--strip-all' as the arguments to `strip'."
(package (inherit p)
(arguments
(let ((a (default-keyword-arguments (package-arguments p)
'(#:configure-flags '()
#:strip-flags '("--strip-debug")))))
(substitute-keyword-arguments a
((#:configure-flags flags)
`(cons* "--disable-shared" "-static" ,flags))
((#:strip-flags flags)
(if strip-all?
''("--strip-all")
flags)))))
(replacement (and=> (package-replacement p) static-package-qt))))
(define qtbase-static (static-package-qt qtbase))
(packages->manifest (cons qtbase-static))
--8<---------------cut here---------------end--------------->8---
Maxim Cournoyer (3):
build: qt-build-system: Allow users to override/extend XDG_DATA_DIRS.
gnu: qtbase: Enable GTK support.
gnu: qtbase: Specify configure flags via the #:configure-flags
argument.
gnu/packages/qt.scm | 168 ++++++++++++++++-----------------
guix/build/qt-build-system.scm | 14 +--
2 files changed, 90 insertions(+), 92 deletions(-)
--
2.32.0
next reply other threads:[~2021-06-25 18:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 18:04 Maxim Cournoyer [this message]
2021-06-25 18:08 ` [bug#49227] [PATCH 1/3] build: qt-build-system: Allow users to override/extend XDG_DATA_DIRS Maxim Cournoyer
2021-06-25 18:08 ` [bug#49227] [PATCH 2/3] gnu: qtbase: Enable GTK support Maxim Cournoyer
2021-06-25 18:08 ` [bug#49227] [PATCH 3/3] gnu: qtbase: Specify configure flags via the #:configure-flags argument Maxim Cournoyer
2021-06-26 16:32 ` [bug#49227] [PATCH 1/3] build: qt-build-system: Allow users to override/extend XDG_DATA_DIRS Maxime Devos
2021-07-02 21:08 ` bug#49227: " Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210625180414.10045-1-maxim.cournoyer@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=49227@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.