From: Michael Rohleder <mike@rohleder.de>
To: 44295@debbugs.gnu.org
Cc: Michael Rohleder <mike@rohleder.de>
Subject: [bug#44295] [PATCH] gnu: emacs-emms: Update to 6.0.
Date: Wed, 28 Oct 2020 22:17:53 +0100 [thread overview]
Message-ID: <20201028211753.28082-1-mike@rohleder.de> (raw)
* gnu/packages/emacs-xyz.scm (emacs-emms): Update to 6.0.
[arguments]: Add substitution for exiftool.
[inputs]: Add perl-image-exiftool.
---
gnu/packages/emacs-xyz.scm | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 49420b2b20..6597b637e9 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1585,14 +1585,14 @@ incrementally confined in Isearch manner.")
(define emacs-emms-print-metadata
(package
(name "emacs-emms-print-metadata")
- (version "5.42")
+ (version "6.0")
(source
(origin
(method url-fetch)
(uri (string-append "https://elpa.gnu.org/packages/"
"emms-" version ".tar"))
(sha256
- (base32 "1khx1fvllrs6w9kxk12mp1hj309c90mc7lkq1vvlqlr7vd6zmnpj"))))
+ (base32 "1zxiic91zhgdkxyfgyh1vkv4lzg90vq362y9k739n28ci6z4xzwm"))))
(build-system gnu-build-system)
(arguments
`(#:make-flags '("emms-print-metadata")
@@ -1630,7 +1630,7 @@ light user interface.")
(modify-phases %standard-phases
(add-after 'unpack 'set-external-programs
;; Specify the absolute file names of the various programs
- ;; so that everything works out-of-the-box.
+ ;; so that everything works out-of-the-box. (tinytag missing)
(lambda* (#:key inputs outputs #:allow-other-keys)
(let ((out (assoc-ref outputs "out"))
(emms-print-metadata (assoc-ref inputs "emms-print-metadata"))
@@ -1640,6 +1640,7 @@ light user interface.")
(mpg321 (assoc-ref inputs "mpg321"))
(mp3info (assoc-ref inputs "mp3info"))
(mutagen (assoc-ref inputs "mutagen"))
+ (exiftool (assoc-ref inputs "perl-image-exiftool"))
(opus (assoc-ref inputs "opus-tools")))
(emacs-substitute-variables "emms-player-mpg321-remote.el"
("emms-player-mpg321-remote-command"
@@ -1673,6 +1674,9 @@ light user interface.")
(substitute* "emms-tag-editor.el"
(("\"mid3v2\"")
(string-append "\"" mutagen "/bin/mid3v2\"")))
+ (substitute* "emms-info-exiftool.el"
+ (("\"exiftool\"")
+ (string-append "\"" exiftool "/bin/exiftool\"")))
#t))))))
(inputs
`(("emms-print-metadata" ,emacs-emms-print-metadata)
@@ -1682,6 +1686,7 @@ light user interface.")
("mpg321" ,mpg321)
("mp3info" ,mp3info)
("mutagen" ,python-mutagen)
+ ("perl-image-exiftool" ,perl-image-exiftool)
("opus-tools" ,opus-tools)))))
(define-public emacs-emms-mode-line-cycle
--
2.29.1
next reply other threads:[~2020-10-28 21:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 21:17 Michael Rohleder [this message]
2020-10-28 21:45 ` bug#44295: [PATCH] gnu: emacs-emms: Update to 6.0 Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028211753.28082-1-mike@rohleder.de \
--to=mike@rohleder.de \
--cc=44295@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.