all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Jakub Kądziołka" <kuba@kadziolka.net>
To: Hendur Saga <hendursaga@yahoo.com>
Cc: 42751@debbugs.gnu.org
Subject: [bug#42751] [PATCH] gnu: Add cfunge.
Date: Sun, 9 Aug 2020 22:50:33 +0200	[thread overview]
Message-ID: <20200809205033.4x5kcm745rk4rdxr@gravity> (raw)
In-Reply-To: <1926083374.1509159.1596819760388@mail.yahoo.com>

[-- Attachment #1: Type: text/plain, Size: 1751 bytes --]

On Fri, Aug 07, 2020 at 05:02:40PM +0000, Hendur Saga wrote:
> I added a new file, esolangs.scm, because I could not find any other place to be more appropriate, for this and forthcoming packages.

Not a bad idea, though toys.scm somewhat fits. Please add the new file
to the list in gnu/local.mk, though.

Also, could you run your code through etc/indent-code.el?

> +   (arguments
> +     '(#:tests? #f)) ; no make target 'test'

The repository does contain a tests/ folder, did you try running these?
You can check the rgbds package from assembly.scm for some inspiration
as to how you can handle a custom testsuite entrypoint.

> +   (inputs
> +    `(("ncurses" ,ncurses)))
> +   (home-page "https://github.com/VorpalBlade/cfunge")
> +   (synopsis "Fast conforming Befunge93/98/109 interpreter in C")
> +   (description "cfunge is a fast conforming Befunge93/98/109 interpreter written in C.
           @command{cfunge}

> +It supports several fingerprints.")

It would be nice to define what a fingerprint is, as even though there
was once a summer when I was fluent in Befunge, I still needed a longer
moment to recall what those are. How about this Texinfo markup?

@dfn{fingerprints} (opt-in language extensions identified by a
four-character code).

> +   (license license:gpl2+)))

COPYING and the headers in src/*.c (well, I checked diagnostic.c)
suggest that it's actually gpl3+, what gives?

Could you send an updated patch?

Regards,
Jakub Kądziołka

P.S. I tried to test the package by running this CGCC answer in it, but
it loops infinitely. I didn't have time to debug this, so I don't know
where the blame lies.

https://codegolf.stackexchange.com/a/150920/55934

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-08-09 20:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1926083374.1509159.1596819760388.ref@mail.yahoo.com>
2020-08-07 17:02 ` [bug#42751] [PATCH] gnu: Add cfunge Hendur Saga via Guix-patches via
2020-08-09 20:50   ` Jakub Kądziołka [this message]
2020-08-15 17:21     ` Hendur Saga via Guix-patches via
2020-12-15 22:02       ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200809205033.4x5kcm745rk4rdxr@gravity \
    --to=kuba@kadziolka.net \
    --cc=42751@debbugs.gnu.org \
    --cc=hendursaga@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.