From: Danny Milosavljevic <dannym@scratchpost.org>
To: R Veera Kumar <vkor@vkten.in>
Cc: 40320@debbugs.gnu.org
Subject: [bug#40320] [PATCH 2/2] gnu: Add qalculate-gtk
Date: Mon, 30 Mar 2020 12:50:13 +0200 [thread overview]
Message-ID: <20200330125013.54640bbc@scratchpost.org> (raw)
In-Reply-To: <e8055db728ed9ac1655d91d17e5dfae6407c7e4b.1585545646.git.vkor@vkten.in>
[-- Attachment #1: Type: text/plain, Size: 751 bytes --]
> + (let ((commit "87f78ab3d7ed0dedf56edc38242d559ac07b1330")
> + (revision "1"))
> + (package
> + (name "qalculate-gtk")
> + (version (git-version "3.8.0" revision commit))
Same as in libqalculate, please use the git tag "v3.8.0" instead.
> + ("automake" ,automake)
> + ("autoconf" ,autoconf)
Why?
> + (add-before 'check 'update-po-files ;; to pass po check
Please use just one semicolon for this kind of comment.
Maybe also include the error message one would get otherwise, as a comment.
> + (lambda _
> + (with-output-to-file "po/POTFILES.skip"
> + (lambda _ (format #t "data/shortcuts.ui~%"))))))))
Please end the phase in #t.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-03-30 10:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 5:22 [bug#40320] [PATCH 1/2] gnu: Add libqalculate R Veera Kumar
2020-03-30 5:27 ` [bug#40320] [PATCH 2/2] gnu: Add qalculate-gtk R Veera Kumar
2020-03-30 10:50 ` Danny Milosavljevic [this message]
2020-03-30 10:45 ` [bug#40320] [PATCH 1/2] gnu: Add libqalculate Danny Milosavljevic
2020-03-31 9:12 ` R Veera Kumar
2020-04-01 5:23 ` [bug#40320] [PATCH v2 " R Veera Kumar
2020-04-01 5:23 ` [bug#40320] [PATCH v2 2/2] gnu: Add qalculate-gtk R Veera Kumar
2020-04-03 13:39 ` bug#40320: " Ludovic Courtès
2020-04-03 13:37 ` [bug#40320] [PATCH v2 1/2] gnu: Add libqalculate Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330125013.54640bbc@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=40320@debbugs.gnu.org \
--cc=vkor@vkten.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.