all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: 40212@debbugs.gnu.org
Cc: Efraim Flashner <efraim@flashner.co.il>
Subject: [bug#40212] [PATCH] gnu: xorriso: Build gui frontend.
Date: Tue, 24 Mar 2020 16:53:21 +0200	[thread overview]
Message-ID: <20200324145321.7569-1-efraim@flashner.co.il> (raw)

* gnu/packages/cdrom.scm (xorriso)[outputs]: Add gui.
[arguments]: Add custom phase to install gui files to separate output
and wrap the binary.
[inputs]: Add tk.
---

A while ago I had to burn a CD (or I thought I did) and I realized I
didn't know how to do it anymore and for some reason it was easier to
build the GUI front-end for xorriso than other options.

Adding tk as an input increases the closure size from about 80 MiB to about
150 MiB so I moved it to a separate output.  Creating a separate package
entirely would be easier, it's literally just adding "tk" as an input.

---
 gnu/packages/cdrom.scm | 25 ++++++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/cdrom.scm b/gnu/packages/cdrom.scm
index d6127d11f9..c760725ba3 100644
--- a/gnu/packages/cdrom.scm
+++ b/gnu/packages/cdrom.scm
@@ -3,7 +3,7 @@
 ;;; Copyright © 2013, 2014 Andreas Enge <andreas@enge.fr>
 ;;; Copyright © 2015 Taylan Ulrich Bayırlı/Kammer <taylanbayirli@gmail.com>
 ;;; Copyright © 2015 Paul van der Walt <paul@denknerd.org>
-;;; Copyright © 2015, 2016, 2017, 2018, 2019 Efraim Flashner <efraim@flashner.co.il>
+;;; Copyright © 2015, 2016, 2017, 2018, 2019, 2020 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2016 Alex Kost <alezost@gmail.com>
 ;;; Copyright © 2016 Marius Bakke <mbakke@fastmail.com>
 ;;; Copyright © 2017 John Darrington <jmd@gnu.org>
@@ -66,6 +66,7 @@
   #:use-module (gnu packages python)
   #:use-module (gnu packages image)
   #:use-module (gnu packages photo)
+  #:use-module (gnu packages tcl)
   #:use-module (gnu packages video)
   #:use-module (gnu packages wget)
   #:use-module (gnu packages xiph))
@@ -156,6 +157,7 @@ libcdio.")
   (package
     (name "xorriso")
     (version "1.5.2")
+    (outputs '("out" "gui"))
     (source (origin
              (method url-fetch)
              (uri (string-append "mirror://gnu/xorriso/xorriso-"
@@ -172,10 +174,31 @@ libcdio.")
              (let* ((out (assoc-ref outputs "out"))
                     (out-bin (string-append out "/bin")))
                (install-file "frontend/grub-mkrescue-sed.sh" out-bin)
+               #t)))
+         (add-after 'install 'move-gui-to-separate-output
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out"))
+                   (gui (assoc-ref outputs "gui"))
+                   (name "xorriso-tcltk"))
+               (mkdir-p (string-append gui "/bin"))
+               (mkdir-p (string-append gui "/share/info"))
+               (mkdir-p (string-append gui "/share/man/man1"))
+               (rename-file
+                 (string-append out "/bin/" name)
+                 (string-append gui "/bin/" name))
+               (rename-file
+                 (string-append out "/share/info/" name ".info")
+                 (string-append gui "/share/info/" name ".info"))
+               (rename-file
+                 (string-append out "/share/man/man1/" name ".1")
+                 (string-append gui "/share/man/man1/" name ".1"))
+               (wrap-program (string-append gui "/bin/" name)
+                 `("PATH" ":" prefix (,(string-append out "/bin"))))
                #t))))))
     (inputs
      `(("acl" ,acl)
        ("readline" ,readline)
+       ("tk" ,tk)
        ("zlib" ,zlib)))
     (home-page "https://www.gnu.org/software/xorriso/")
     (synopsis "Create, manipulate, burn ISO-9660 file systems")
-- 
2.26.0

             reply	other threads:[~2020-03-24 14:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-24 14:53 Efraim Flashner [this message]
2020-03-26 17:55 ` [bug#40212] [PATCH] gnu: xorriso: Build gui frontend Thomas Schmitt
2020-04-10 10:51 ` bug#40212: " Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200324145321.7569-1-efraim@flashner.co.il \
    --to=efraim@flashner.co.il \
    --cc=40212@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.