all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: R Veera Kumar <vkor@vkten.in>
Cc: 40209@debbugs.gnu.org
Subject: [bug#40209] [PATCH] gnu: qiv: Add new pkg qiv an image viewer for X
Date: Tue, 24 Mar 2020 13:04:35 +0100	[thread overview]
Message-ID: <20200324130435.53b67995@scratchpost.org> (raw)
In-Reply-To: <20200324103316.GA3324@tulip>

[-- Attachment #1: Type: text/plain, Size: 691 bytes --]

Hi Veera,

in order to make this actually work in a Guix release, please refer to the new
file in gnu/local.mk in GNU_SYSTEM_MODULES .

Or better yet, in this case I would prefer if you just added qiv to the existing
file gnu/packages/image-viewers.scm .

>+       #:tests? #f

Why?  Please add a comment.

It seems that the changelog mentions that the tests are now in "make install".
Did the tests work?

>+       #:make-flags
>+        (list
>+          "CC=gcc"
>+          "LCMS="
>+          (string-append "PREFIX=" (assoc-ref %outputs "out")))))

Indentation is off.

Otherwise it looks good.

Could you send a v2 of your patch with these points addressed?

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2020-03-24 12:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-24  9:36 [bug#40209] [PATCH] gnu: qiv: Add qiv image viewer for X R Veera Kumar
2020-03-24 10:33 ` [bug#40209] [PATCH] gnu: qiv: Add new pkg qiv an " R Veera Kumar
2020-03-24 12:04   ` Danny Milosavljevic [this message]
2020-03-25  8:08 ` [bug#40209] [PATCH v2] gnu: image-viewers: " R Veera Kumar
2020-03-31 13:38   ` Danny Milosavljevic
2020-03-31 11:03 ` [bug#40209] [PATCH v3] gnu: Add qiv R Veera Kumar
2020-03-31 11:17   ` Danny Milosavljevic
2020-03-31 11:53     ` R Veera Kumar
2020-04-01  1:07 ` [bug#40209] [PATCH v4] " R Veera Kumar
2020-04-01 10:20   ` bug#40209: " Danny Milosavljevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200324130435.53b67995@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=40209@debbugs.gnu.org \
    --cc=vkor@vkten.in \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.