all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Evan Straw <evan.straw99@gmail.com>
Cc: 39796@debbugs.gnu.org
Subject: [bug#39796] [PATCH] gnu: Add guile-websocket.
Date: Sun, 15 Mar 2020 14:36:07 -0400	[thread overview]
Message-ID: <20200315183607.GF5561@jasmine.lan> (raw)
In-Reply-To: <87o8tlewxf.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1191 bytes --]

On Tue, Feb 25, 2020 at 09:31:56PM -0800, Evan Straw wrote:
> From ba695ba2cbf27014e1ed95da8a0620988f03fa54 Mon Sep 17 00:00:00 2001
> From: Evan Straw <evan.straw99@gmail.com>
> Date: Tue, 25 Feb 2020 12:08:46 -0800
> Subject: [PATCH] gnu: Add guile-websocket.
> 
> * gnu/packages/guile-xyz.scm (guile-websocket): New variable.

Thanks for this patch!

Overall looks good, but the hash of the source code is not correct for
me:

------
r:sha256 hash mismatch for /gnu/store/f4gz64dfsqmhbbg24ggzf9ffcr6k2znf-guile-websocket-0.1-checkout:
  expected hash: 10r8384frlyrljjdyzilrh8hzi60v9hisx4fxjs7rmg9g01cs77k
  actual hash:   1hymvsfrmq9qxr5cxnsgdz7y757yp1cpsgxmdp3f5wxxxpqgsmzx
hash mismatch for store item '/gnu/store/f4gz64dfsqmhbbg24ggzf9ffcr6k2znf-guile-websocket-0.1-checkout'
build of /gnu/store/n6kxplhzysqq4d82p1m2wa2y48lbgswb-guile-websocket-0.1-checkout.drv failed
------

My guess is that you already had something corresponding to the expected
hash in /gnu/store, and so Guix did not even try to clone the upstream
repo. Probably another commit of guile-websocket, assuming the package
did build for you.

Can you take a look and send a revised patch?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-03-15 18:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-26  5:31 [bug#39796] [PATCH] gnu: Add guile-websocket Evan Straw
2020-03-15 18:36 ` Leo Famulari [this message]
2020-03-24 17:53   ` Ludovic Courtès
2020-03-28  3:09     ` [bug#39796] [PATCH v2] " Evan Straw
2020-03-29 14:10       ` bug#39796: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200315183607.GF5561@jasmine.lan \
    --to=leo@famulari.name \
    --cc=39796@debbugs.gnu.org \
    --cc=evan.straw99@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.