all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Jakub Kądziołka" <kuba@kadziolka.net>
To: raingloom <raingloom@riseup.net>
Cc: 39675@debbugs.gnu.org
Subject: [bug#39675] [PATCH] fix Desmume on newer GCC
Date: Sat, 22 Feb 2020 16:39:49 +0100	[thread overview]
Message-ID: <20200222153949.fkr5xlbmbm6y4mvp@gravity> (raw)
In-Reply-To: <1582363891.3461.0@riseup.net>

[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]

On Sat, Feb 22, 2020 at 10:31:31AM +0100, raingloom wrote:
> Ah, I forgot to leave a blank line in the commit message.
> 
> Here is a patch for the current master as of a few minutes ago.

Something is still off:

patching file src/MMU_timing.h
Hunk #1 FAILED at 155 (different line endings).
1 out of 1 hunk FAILED -- saving rejects to file src/MMU_timing.h.rej
patching file src/ctrlssdl.cpp
patching file src/wifi.cpp
Hunk #1 succeeded at 314 (offset -6 lines).
source is under 'desmume-0.9.11'
applying '/gnu/store/yc9991nl8vgkyszbb77ywr9idikyi5lj-desmume-gcc6-fixes.patch'...
Backtrace:
           3 (primitive-load "/gnu/store/zxjsjnfbzqqz2zgks5xgkh63m30…")
In ice-9/eval.scm:
    619:8  2 (_ #(#<directory (guile-user) 7ffff5c70140> "desmume-…"))
In srfi/srfi-1.scm:
    640:9  1 (for-each #<procedure apply-patch (a)> ("/gnu/store/…" …))
In guix/build/utils.scm:
    652:6  0 (invoke _ . _)

guix/build/utils.scm:652:6: In procedure invoke:
Throw to key `srfi-34' with args `(#<condition &invoke-error [program: "/gnu/store/v76scv4n63ip08g119rczh2mrw31zwpd-patch-2.7.6/bin/patch" arguments: ("--force" "--no-backup-if-mismatch" "-p1" "--input" "/gnu/store/yc9991nl8vgkyszbb77ywr9idikyi5lj-desmume-gcc6-fixes.patch") exit-status: 1 term-signal: #f stop-signal: #f] 7ffff6022d00>)'.

`file src/MMU_timing.h` in the build directory suggests that the header
file is shipped with CRLF line endings. Could `git format-patch` be
converting \r\n in your files into plain \n?

I tried to work around this with some combinations of
(origin (patch-flags '("--ignore-whitespace" "-p1"))), but no results.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-02-22 15:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-19 13:41 [bug#39675] [PATCH] fix Desmume on newer GCC raingloom
2020-02-20 16:04 ` Jakub Kądziołka
2020-02-22  9:31   ` raingloom
2020-02-22 15:39     ` Jakub Kądziołka [this message]
2020-02-22 23:19       ` raingloom
2020-02-23 19:31 ` bug#39675: Done: " Jakub Kądziołka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200222153949.fkr5xlbmbm6y4mvp@gravity \
    --to=kuba@kadziolka.net \
    --cc=39675@debbugs.gnu.org \
    --cc=raingloom@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.