all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: guix-devel@gnu.org
Subject: patch-shebang and Rust - Change on core-updates?
Date: Mon, 20 Jan 2020 20:28:14 +0100	[thread overview]
Message-ID: <20200120202814.3ad015d0@scratchpost.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 760 bytes --]

Hi,

Rust uses #![...] for something that is definitely not a shebang
(file-wide feature tests).

Currently, our patch-shebang[1] emits a lot of warnings because of those.

Should we change patch-shebang to ignore lines starting with "#![" ?

If so, how?  There's some get-char* magic that I don't understand.

The easiest way would be to add peek-char after the two calls to get-char*,
but not sure if that would work.

Alternatively, we could adapt the regexp.

>(define patch-shebang
>  (let ((shebang-rx (make-regexp "^[[:blank:]]*([[:graph:]]+)[[:blank:]]*([[:graph:]]*)(.*)$")))

The [[:graph:]]+ would have to change to something like 

  [[:graph-without-opening-bracket:]][[:graph:]]+

[1] ./guix/build/utils.scm patch-shebang

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2020-01-20 19:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-20 19:28 Danny Milosavljevic [this message]
2020-01-20 23:24 ` patch-shebang and Rust - Change on core-updates? Andreas Rottmann
2020-01-25 17:26 ` Ludovic Courtès
2020-02-17 15:55   ` Danny Milosavljevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200120202814.3ad015d0@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.