From: Josh Holland <josh@inv.alid.pw>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 35653@debbugs.gnu.org
Subject: [bug#35653] [PATCH] gnu: Add rcm.
Date: Thu, 9 May 2019 18:59:15 +0100 [thread overview]
Message-ID: <20190509175916.22479-1-josh@inv.alid.pw> (raw)
In-Reply-To: <20190509185256.309d9b63@scratchpost.org>
Danny Milosavljevic writes:
> Yes, and it's not so important in which module what is.
I'll just leave it in its own module for now then, and if a maintainer
wants to move it either when it's merged or later down the line that's
fine.
> From your description, try (#:parallel-tests? #f) instead of (#:tests? #f).
Oh of course, that makes perfect sense! That fixes it and all the tests
pass now.
> Some test scripts still have /bin/sh
AFAICT the only one I'm not patching is `test/rcup-standalone.t` and
that's kind of a weird one, because it's testing the feature to output a
standalone shell script rather than run it. Changing that would require
patching the rcup script itself and I don't think that's worth it,
especially as the script uses the bash default value syntax to allow
all the commands to be overriden.
If I'm still operating git send-email correctly, a new patch should be
attached with these changes, and a better commit message. I also updated
`gnu/local.mk` because that seems to be a thing I forgot initially.
Thanks,
Josh
next prev parent reply other threads:[~2019-05-09 18:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 15:38 [bug#35653] [PATCH] gnu: Add rcm Josh Holland
2019-05-09 16:52 ` Danny Milosavljevic
2019-05-09 17:59 ` Josh Holland [this message]
2019-05-09 17:59 ` [bug#35653] [PATCH v2] " Josh Holland
2019-12-10 6:55 ` Brett Gilio
2020-01-15 21:42 ` bug#35653: " Ludovic Courtès
2020-01-02 15:11 ` [bug#35653] " Jakub Kądziołka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190509175916.22479-1-josh@inv.alid.pw \
--to=josh@inv.alid.pw \
--cc=35653@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.