[bug#35545] [PATCH 07/17] gnu: Add java-openjfx-build.

[Julien Lepiller <julien@lepiller.eu>]

Le Sat, 04 May 2019 13:48:57 +0200,
Ricardo Wurmus <rekado@elephly.net> a écrit :

> Julien Lepiller <julien@lepiller.eu> writes:
> 
> > * gnu/packages/java.scm (java-openjfx-build): New variable.  
> […]
> > +    ;; This is a java-8 version
> > +    (version "8.202")  
> 
> What does this imply?  Are there more recent versions?

This is the most recent version for the java 8 version, but there are
newer versions for newer compilers that are not compatible with java 8.

> 
> > +    (source (origin
> > +              (method url-fetch)
> > +              (uri (string-append
> > "http://hg.openjdk.java.net/openjfx/8u-dev/rt"
> > +                                  "/archive/85d09981ae0d.tar.gz"))
> > +              (file-name (string-append name "-" version
> > ".tar.gz"))  
> 
> I think it may be better to use hg-fetch here as this doesn’t look
> like a stable tarball.
> 
> > +    (description "OpenJFX is a free, next generation client
> > application +platform for desktop, mobile and embedded systems
> > built on Java.  Its goal +is to produce a modern, efficient, and
> > fully featured toolkit for developing +rich client applications.
> > This package contains base classes for the +OpenJFX distribution
> > and helper classes for building other parts of the
> > +distribution.")  
> 
> I agree with what Nicolas wrote.
> 
> > +    (license license:gpl2)));with classpath exception  
> 
> GPL2 only?  Please add a space before “;”.
>