all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: 34838@debbugs.gnu.org
Subject: [bug#34838] [PATCH 0/6] Add '--with-git-url' and make sure it composes well
Date: Wed, 13 Mar 2019 10:57:55 +0100	[thread overview]
Message-ID: <20190313095755.15378-1-ludo@gnu.org> (raw)

Hello Guix!

This patch series allows for things like this:

  guix build python-numpy \
    --with-git-url=python=https://github.com/python/cpython \
    --with-commit=python=86900a49000c4a96ad1dc34e49d8af4245b08843

Initially I just wanted to add a ‘--with-git-url’ transformation option,
but then allowing it to be combined with ‘--with-branch’, for example,
turned out to be more involved.

To achieve that, this patch series changes transformation options so
they match packages by spec (“guile”, “guile@2”, etc.) instead of
matching them by identity as was the case before (specifically, we’d
get the identity of the package to be replaced with ‘specification->package’.)

That leads to a slight semantic change: transformations now apply
to any package that matches the given spec, whereas before they would
only apply to the public package that matches the spec.  In practice,
it probably doesn’t make any difference since there are rarely (if ever)
several distinct packages with the same name.

Feedback welcome!

Ludo’.

Ludovic Courtès (6):
  guix build: Add '--with-git-url'.
  packages: Add 'package-input-rewriting/spec'.
  guix build: Factorize 'package-git-url'.
  guix build: Transformation options match packages by spec.
  guix build: '--with-commit' makes recursive checkouts.
  guix build: '--with-branch' strips slashes from the version string.

 doc/guix.texi           |  61 ++++++++++++++---
 guix/packages.scm       |  38 +++++++++++
 guix/scripts/build.scm  | 146 +++++++++++++++++++++++++++-------------
 tests/packages.scm      |  51 ++++++++++++++
 tests/scripts-build.scm | 109 ++++++++++++++++++++++++++++--
 5 files changed, 343 insertions(+), 62 deletions(-)

-- 
2.21.0

             reply	other threads:[~2019-03-13  9:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-13  9:57 Ludovic Courtès [this message]
2019-03-13 10:47 ` [bug#34838] [PATCH 1/6] guix build: Add '--with-git-url' Ludovic Courtès
2019-03-13 10:47   ` [bug#34838] [PATCH 2/6] packages: Add 'package-input-rewriting/spec' Ludovic Courtès
2019-03-13 10:47   ` [bug#34838] [PATCH 3/6] guix build: Factorize 'package-git-url' Ludovic Courtès
2019-03-13 10:47   ` [bug#34838] [PATCH 4/6] guix build: Transformation options match packages by spec Ludovic Courtès
2019-03-13 10:47   ` [bug#34838] [PATCH 5/6] guix build: '--with-commit' makes recursive checkouts Ludovic Courtès
2019-03-13 10:47   ` [bug#34838] [PATCH 6/6] guix build: '--with-branch' strips slashes from the version string Ludovic Courtès
2019-03-17 21:56 ` bug#34838: [PATCH 0/6] Add '--with-git-url' and make sure it composes well Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190313095755.15378-1-ludo@gnu.org \
    --to=ludo@gnu.org \
    --cc=34838@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.