all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eric Bavier <ericbavier@centurylink.net>
To: "Jovany Leandro G.C" <bit4bit@riseup.net>
Cc: 31382-done@debbugs.gnu.org
Subject: bug#31382: [PATCH] telephony: add twinkle
Date: Tue, 8 May 2018 22:14:35 -0500	[thread overview]
Message-ID: <20180508221435.0886c787@centurylink.net> (raw)
In-Reply-To: <20180507173523.690a6acd@riseup.net>

[-- Attachment #1: Type: text/plain, Size: 2001 bytes --]

Hello Jovany,

On Mon, 7 May 2018 17:35:23 -0500
"Jovany Leandro G.C" <bit4bit@riseup.net> wrote:

> From 1a2504b36e0775443587faf43e3a2d9467769866 Mon Sep 17 00:00:00 2001
> From: "Jovany Leandro G.C" <bit4bit@riseup.net>
> Date: Mon, 7 May 2018 17:32:57 -0500
> Subject: [PATCH] telephony: add twinkle
> 
> ---
>  gnu/packages/telephony.scm | 66 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 66 insertions(+)

LGTM.  It even builds with --check/--rounds ! :)   Thanks.

I pushed this in commit b61cb24492c150b5eebb5227f2a7c32e4d42e1d4 with
the slight modifications below:


diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
index fe763c517..40e57051e 100644
--- a/gnu/packages/telephony.scm
+++ b/gnu/packages/telephony.scm
@@ -31,6 +31,7 @@
   #:use-module (gnu packages avahi)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages check)
+  #:use-module (gnu packages file)
   #:use-module (gnu packages protobuf)
   #:use-module (gnu packages gnupg)
   #:use-module (gnu packages linux)
@@ -51,6 +52,7 @@
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix git-download)
+  #:use-module (guix build-system cmake)
   #:use-module (guix build-system gnu))
 
 (define-public commoncpp
@@ -542,9 +544,9 @@ Mumble consists of two applications for separate usage:
       ("qtdeclarative" ,qtdeclarative)
       ("qtquickcontrols" ,qtquickcontrols)))
    (home-page "http://twinkle.dolezel.info/")
-   (synopsis "Softphone for your voice over IP and instant messaging communcations")
+   (synopsis "Softphone for voice over IP and instant messaging")
    (description "Twinkle is a softphone for your voice over IP and instant
 messaging communcations using the SIP protocol.  You can use it for direct IP
 phone to IP phone communication or in a network using a SIP proxy to route your
 calls and messages")
-   (license license:gpl2))))
+   (license license:gpl2+))))



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2018-05-09  3:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-07 22:35 [bug#31382] [PATCH] telephony: add twinkle Jovany Leandro G.C
2018-05-09  3:14 ` Eric Bavier [this message]
2018-05-09 20:22 ` [bug#31382] [PATCH] telephony: twinkle fix support for codec speex Jovany Leandro G.C
2018-05-10  1:46   ` Eric Bavier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180508221435.0886c787@centurylink.net \
    --to=ericbavier@centurylink.net \
    --cc=31382-done@debbugs.gnu.org \
    --cc=bit4bit@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.