all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 31333@debbugs.gnu.org
Subject: [bug#31333] [PATCH 01/22] gnu: Add groovy-java-bootstrap.
Date: Mon, 7 May 2018 19:58:53 +0200	[thread overview]
Message-ID: <20180507195853.14b363aa@scratchpost.org> (raw)
In-Reply-To: <20180501154449.3531-1-julien@lepiller.eu>

[-- Attachment #1: Type: text/plain, Size: 1452 bytes --]

Hi Julien,

On Tue,  1 May 2018 17:44:28 +0200
Julien Lepiller <julien@lepiller.eu> wrote:

> +  %D%/packages/patches/groovy-Add-exceptionutilsgenerator.patch	\

Capital letter?  Ok I guess, just uncommon.

> +              (uri (string-append "https://github.com/apache/groovy/archive/GROOVY_"
> +                                  (string-map (lambda (x) (if (eq? x #\.) #\_ x)) version)
> +                                  ".tar.gz"))

Hmm, is testing using "eq?" safe?  I'd prefer "char=?".  Even more, I'd prefer using (match ...).

> +    (license (list license:gpl2
> +                   license:cddl1.1))))

Does that mean "AND" or "OR"?  Please add a comment.

> diff --git a/gnu/packages/patches/groovy-Add-exceptionutilsgenerator.patch b/gnu/packages/patches/groovy-Add-exceptionutilsgenerator.patch
> new file mode 100644
> index 000000000..3c81f28cf
> --- /dev/null
> +++ b/gnu/packages/patches/groovy-Add-exceptionutilsgenerator.patch
> @@ -0,0 +1,96 @@
> +From 3dbdc68093e90f0ef9b77b70490d8e0b1dcfbf8f Mon Sep 17 00:00:00 2001
> +From: Julien Lepiller <julien@lepiller.eu>
> +Date: Sun, 17 Sep 2017 21:08:45 +0200
> +Subject: [PATCH] Add ExceptionUtilsGenerator.java from previous versions
> +
> +This is replaced by a gradle task, but gradle depends on groovy, so we
> +need so way to generate the file without gradle.

It might make sense to add a comment which version exactly this was copied from.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2018-05-07 17:59 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-01 15:41 [bug#31333] [PATCH] Add groovy Julien Lepiller
2018-05-01 15:44 ` [bug#31333] [PATCH 01/22] gnu: Add groovy-java-bootstrap Julien Lepiller
2018-05-01 15:44   ` [bug#31333] [PATCH 02/22] gnu: Add groovy-bootstrap Julien Lepiller
2018-05-06 17:48     ` Danny Milosavljevic
2018-05-06 18:12       ` Julien Lepiller
2018-05-01 15:44   ` [bug#31333] [PATCH 03/22] gnu: Add groovy-tests-bootstrap Julien Lepiller
2018-05-07 18:01     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 04/22] gnu: Add groovy-test Julien Lepiller
2018-05-07 18:01     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 05/22] gnu: Add groovy-xml Julien Lepiller
2018-05-07 18:03     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 06/22] gnu: Add groovy-templates Julien Lepiller
2018-05-07 18:03     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 07/22] gnu: Add groovy-groovydoc Julien Lepiller
2018-05-07 18:04     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 08/22] gnu: Add groovy-ant Julien Lepiller
2018-05-07 18:05     ` Danny Milosavljevic
2018-05-07 19:04       ` Julien Lepiller
2018-05-01 15:44   ` [bug#31333] [PATCH 09/22] gnu: Add groovy-bsf Julien Lepiller
2018-05-07 18:07     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 10/22] gnu: Add groovy-swing Julien Lepiller
2018-05-07 18:09     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 11/22] gnu: Add groovy-console Julien Lepiller
2018-05-07 18:10     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 12/22] gnu: Add groovy-docgenerator Julien Lepiller
2018-05-07 18:10     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 13/22] gnu: Add groovy-groovysh Julien Lepiller
2018-05-07 18:11     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 14/22] gnu: Add groovy-jmx Julien Lepiller
2018-05-07 18:13     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 15/22] gnu: Add groovy-json Julien Lepiller
2018-05-07 18:13     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 16/22] gnu: Add groovy-jsr223 Julien Lepiller
2018-05-07 18:14     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 17/22] gnu: Add groovy-nio Julien Lepiller
2018-05-07 18:15     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 18/22] gnu: Add groovy-servlet Julien Lepiller
2018-05-07 18:15     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 19/22] gnu: Add groovy-sql Julien Lepiller
2018-05-07 18:16     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 20/22] gnu: Add groovy-testng Julien Lepiller
2018-05-07 18:16     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 21/22] gnu: Add groovy-macro Julien Lepiller
2018-05-07 18:17     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 22/22] gnu: Add groovy Julien Lepiller
2018-05-07 19:23     ` Danny Milosavljevic
2018-05-07 17:58   ` Danny Milosavljevic [this message]
2018-05-07 19:25   ` [bug#31333] [PATCH 01/22] gnu: Add groovy-java-bootstrap Björn Höfling
2018-05-09 11:40 ` bug#31333: [PATCH] Add groovy Julien Lepiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180507195853.14b363aa@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=31333@debbugs.gnu.org \
    --cc=julien@lepiller.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.