From: Danny Milosavljevic <dannym@scratchpost.org>
To: Martin Castillo <castilma@uni-bremen.de>
Cc: 30916@debbugs.gnu.org, ng0 <ng0@n0.is>
Subject: bug#30916: Request: add a short description field for os-configuration
Date: Sat, 24 Mar 2018 17:54:38 +0100 [thread overview]
Message-ID: <20180324175438.2ff4e55e@scratchpost.org> (raw)
In-Reply-To: <017b6770-3168-5d63-3dd5-e6c3b590f527@uni-bremen.de>
[-- Attachment #1: Type: text/plain, Size: 2240 bytes --]
Hi Martin,
On Sat, 24 Mar 2018 14:56:03 +0100
Martin Castillo <castilma@uni-bremen.de> wrote:
> ng0 wrote:
> > So basically you want a field in the operating-system declaration where you
> > can _manually_ set a description of a certain maximum length which will be
> > added to the GRUB entry of the generated system generation?
> yes
I wonder whether this description can be generated instead - we have all
the information we need - the packages, the users that are there etc.
Or a description could be generated only if a custom description is not specified.
In fact it's easy to add this and would be a nice intro project for a
person interested in Guix development. I can mentor.
The thing used to fill the Guix bootloader entries is <boot-parameters>.
There's a procedure "operating-system-boot-parameters" which is used
to generate <boot-parameters> instances from an <operating-system>
declaration.
(operating-system-bootcfg calls operating-system-boot-parameters)
(perform-action calls operating-system-bootcfg)
(perform-action is in the top-level guix script)
<boot-parameters> are serialized to disk into:
/var/guix/profiles/system-704-link$ cat parameters
(boot-parameters (version 0) (label "GNU with Linux-Libre 4.14.14 (beta)") (root-device "dayas:/") (kernel "/gnu/store/fnk2xhicbrjsvbq082p6x0ch6npkrg0z-linux-libre-4.14.14/bzImage") (kernel-arguments ("crashkernel=256M" "modprobe.blacklist=pcspkr,snd_pcsp" "quiet" "acpi_osi=Linux" "clocksource=acpi_pm" "allow-discards" "root_trim=yes")) (initrd "/gnu/store/nvhkdssz1m1p8xrggi78y8pd7jz4p3ng-raw-initrd/initrd") (bootloader-name grub) (store (device "dayas:/") (mount-point "/")))
But I wouldn't change the serialization format or what fields <boot-parameters> contain.
Just change operating-system-bootcfg to take a "description" parameter.
And change operating-system-boot-parameters to take a "description" parameter and
use it to calculate the label.
And change perform-action to calculate the value for to "description" parameter in this way:
- Taking it from <operating-system> (or the command line?)
- Falling back to an automatic value (comparing it to the previous generation) otherwise.
That's it.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-03-24 17:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 12:51 bug#30916: Request: add a short description field for os-configuration Martin Castillo
2018-03-23 14:15 ` ng0
2018-03-24 12:33 ` Martin Castillo
2018-03-24 12:45 ` ng0
2018-03-24 13:56 ` Martin Castillo
2018-03-24 16:54 ` Danny Milosavljevic [this message]
2018-03-24 17:00 ` ng0
2018-03-26 13:05 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180324175438.2ff4e55e@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=30916@debbugs.gnu.org \
--cc=castilma@uni-bremen.de \
--cc=ng0@n0.is \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.