all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 30417@debbugs.gnu.org
Subject: [bug#30417] [PATCH 01/11] gnu: Add java-plexus-component-annotations.
Date: Mon, 12 Feb 2018 00:36:01 +0100	[thread overview]
Message-ID: <20180212003601.494e2979@alma-ubu> (raw)
In-Reply-To: <20180210230438.26794-1-julien@lepiller.eu>

On Sun, 11 Feb 2018 00:04:28 +0100
Julien Lepiller <julien@lepiller.eu> wrote:

> * gnu/packages/java.scm (java-plexus-component-annotations): New
> variable.
> ---
>  gnu/packages/java.scm | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> index e714a031c..b7f3fd54e 100644
> --- a/gnu/packages/java.scm
> +++ b/gnu/packages/java.scm
> @@ -2662,6 +2662,17 @@ archives (jar).")
>       `(("archiver" ,java-plexus-archiver)
>         ("hamcrest" ,java-hamcrest-core)))))
>  
> +(define-public java-plexus-component-annotations
> +  (package
> +    (inherit java-plexus-container-default)
> +    (name "java-plexus-component-annotations")
> +    (arguments
> +     `(#:jar-name "plexus-component-annotations.jar"
> +       #:source-dir "plexus-component-annotations/src/main/java"
> +       #:tests? #f)); no tests
> +    (inputs '())
> +    (native-inputs '())))
> +
>  (define-public java-asm
>    (package
>      (name "java-asm")

* This one inherits java-plexus-container-default, but does not adapt
synopsis/description. Is that OK?

* Sorry for being so late, but I also looked into the
  java-plexus-container-default-bootstrap: It contains some jar's in
  the test path. Is that OK?

find . -name "*.jar"
./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/test/test-components/component-a-2.0-SNAPSHOT.jar
./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/test/test-components/plexus-archiver-1.0-alpha-8.jar
./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/test/test-components/component-c-1.0-SNAPSHOT.jar
./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/test/test-components/plugin1-1.0-SNAPSHOT.jar
./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/test/test-components/component-b-1.0-SNAPSHOT.jar
./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/test/test-components/component-a-1.0-SNAPSHOT.jar
./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/test/test-components/plugin0-1.0-SNAPSHOT.jar
./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/test/resources/jar-repository/c.jar
./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/test/resources/jar-repository/b.jar
./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/test/resources/jar-repository/d.jar
./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/test/resources/jar-repository/a.jar

* We have a java-plexus-container-default and
  java-plexus-container-default-bootstrap. Both are "define-public".
  Should we make the bootstrap non-public?

Otherwise, LGTM.

And even though I have my comments, thanks for all this
awesome Java/Maven work!

Björn

  reply	other threads:[~2018-02-11 23:37 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-10 22:48 [bug#30417] [PATCH] java-plexus and java-modello Julien Lepiller
2018-02-10 23:04 ` [bug#30417] [PATCH 01/11] gnu: Add java-plexus-component-annotations Julien Lepiller
2018-02-11 23:36   ` Björn Höfling [this message]
2018-02-10 23:04 ` [bug#30417] [PATCH 02/11] gnu: Add java-plexus-cipher Julien Lepiller
2018-02-11 23:42   ` Björn Höfling
2018-02-10 23:04 ` [bug#30417] [PATCH 03/11] gnu: Add java-plexus-compiler-api Julien Lepiller
2018-02-11 23:47   ` Björn Höfling
2018-02-14 19:18     ` Björn Höfling
2018-02-10 23:04 ` [bug#30417] [PATCH 04/11] gnu: Add java-plexus-compiler-javac Julien Lepiller
2018-02-14 19:23   ` Björn Höfling
2018-02-10 23:04 ` [bug#30417] [PATCH 05/11] gnu: Add java-sisu-build-api Julien Lepiller
2018-02-14 19:53   ` Björn Höfling
2018-02-10 23:04 ` [bug#30417] [PATCH 06/11] gnu: Add java-modello-core Julien Lepiller
2018-02-14 20:22   ` Björn Höfling
2018-02-14 21:56     ` Julien Lepiller
2018-02-16 19:16       ` Björn Höfling
2018-02-17 15:06         ` Marius Bakke
2018-02-24 21:11           ` Julien Lepiller
2018-02-24 21:20             ` Marius Bakke
2018-02-10 23:04 ` [bug#30417] [PATCH 07/11] gnu: Add java-modello-plugins-java Julien Lepiller
2018-02-14 20:34   ` Björn Höfling
2018-02-10 23:04 ` [bug#30417] [PATCH 08/11] gnu: Add java-modello-plugins-xml Julien Lepiller
2018-02-14 20:37   ` Björn Höfling
2018-02-10 23:04 ` [bug#30417] [PATCH 09/11] gnu: Add java-modello-test Julien Lepiller
2018-02-14 20:39   ` Björn Höfling
2018-02-10 23:04 ` [bug#30417] [PATCH 10/11] gnu: Add java-modello-plugins-xpp3 Julien Lepiller
2018-02-14 20:43   ` Björn Höfling
2018-02-10 23:04 ` [bug#30417] [PATCH 11/11] gnu: Add java-plexus-sec-dispatcher Julien Lepiller
2018-02-14 20:59   ` Björn Höfling
2018-02-14 21:02     ` Björn Höfling
2018-02-25 11:08 ` bug#30417: [PATCH] java-plexus and java-modello Julien Lepiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180212003601.494e2979@alma-ubu \
    --to=bjoern.hoefling@bjoernhoefling.de \
    --cc=30417@debbugs.gnu.org \
    --cc=julien@lepiller.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.