From: Danny Milosavljevic <dannym@scratchpost.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 30358@debbugs.gnu.org
Subject: [bug#30358] [PATCH] gnu: Add gpxsee.
Date: Mon, 5 Feb 2018 17:47:57 +0100 [thread overview]
Message-ID: <20180205174757.11e2c71a@scratchpost.org> (raw)
In-Reply-To: <20180205142108.22320-1-m.othacehe@gmail.com>
Hi Mathieu,
On Mon, 5 Feb 2018 15:21:08 +0100
Mathieu Othacehe <m.othacehe@gmail.com> wrote:
> + (for-each (lambda (file)
> + (system* "lrelease" file))
> + (find-files "lang" "\\.ts"))
Please add comment that that's for translation.
> + (substitute* "src/config.h"
> + (("/usr/share/gpxsee")
> + (string-append
> + (assoc-ref outputs "out") "/share/gpxsee/")))
Why once with, once without slash at the end?
> + (zero?
> + (system* "qmake"
> + (string-append "PREFIX="
> + (assoc-ref outputs "out"))))))
Please use "invoke".
> + (synopsis "GPX file viewer and analyser")
> + (description
> + "GPXSee is a Qt-based GPS log file viewer and analyzer that supports GPX,
> +TCX, KML, FIT, IGC and NMEA files.")
"analyser" or "analyzer" ?
Otherwise LGTM!
next prev parent reply other threads:[~2018-02-05 16:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 14:21 [bug#30358] [PATCH] gnu: Add gpxsee Mathieu Othacehe
2018-02-05 16:47 ` Danny Milosavljevic [this message]
2018-02-06 10:04 ` Mathieu Othacehe
2018-02-06 14:52 ` bug#30358: " Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180205174757.11e2c71a@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=30358@debbugs.gnu.org \
--cc=m.othacehe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.