all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: core-updates, let’s go!
Date: Sun, 31 Dec 2017 12:14:16 +0100	[thread overview]
Message-ID: <20171231121416.5df20c3b@scratchpost.org> (raw)
In-Reply-To: <20171231103219.GB5133@macbook41>

I'd like to get the patch

    [bug#29856] [PATCH core-updates] guix: python-build-system:  Modify ".py" files in-place.

into this core-updates cycle.  What do you all think?

If we don't do it then a lot of Python programs (the ones who use "console_scripts" in setup.py as they should) will not work (because we emit a shell script wrapper and Python tries to import it - that's going to end badly).  On the other hand, I don't know the effect on other programs (read: I didn't build the world with it - but I did build quite a few Python programs).  You can try it with the guix package ledger-agent and try to invoke "ledger-agent".

The patch only affects files whose names end in ".py" since Python's importer will only find those in any case.  So its possible ill effect is limited.

Hartmut, what do you think?

  reply	other threads:[~2017-12-31 11:14 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-31 10:27 core-updates, let’s go! Ludovic Courtès
2017-12-31 10:32 ` Efraim Flashner
2017-12-31 11:14   ` Danny Milosavljevic [this message]
2017-12-31 12:20     ` Danny Milosavljevic
2017-12-31 15:07     ` Marius Bakke
2017-12-31 17:27       ` Ricardo Wurmus
2018-01-02 18:12         ` change to the wrap-program procedure (was: core-updates, let’s go!) Hartmut Goebel
2018-01-02 19:01           ` Ricardo Wurmus
2018-01-02 19:19             ` change to the wrap-program procedure Hartmut Goebel
2018-01-02 20:47               ` Ricardo Wurmus
2017-12-31 14:44 ` core-updates, let’s go! Marius Bakke
2018-01-01 17:12   ` Ludovic Courtès
2018-01-01 19:08     ` Efraim Flashner
2018-01-03 18:35     ` Leo Famulari
2018-01-03 20:06       ` Leo Famulari
2018-01-03 19:34     ` Leo Famulari
2018-01-18  3:50     ` Leo Famulari
2018-01-20  0:51       ` core-updates: SELinux Leo Famulari
2018-01-28 12:32         ` Ricardo Wurmus
2018-01-20 20:57       ` core-updates, let’s go! Kei Kebreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171231121416.5df20c3b@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=efraim@flashner.co.il \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.