From: Christopher Baines <mail@cbaines.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 28805@debbugs.gnu.org
Subject: [bug#28805] [PATCH] gnu: Add emacs-org-plus-contrib.
Date: Sun, 15 Oct 2017 21:11:23 +0100 [thread overview]
Message-ID: <20171015211123.08bbae84@cbaines.net> (raw)
In-Reply-To: <877evwurfm.fsf@gnu.org>
[-- Attachment #1.1: Type: text/plain, Size: 2282 bytes --]
On Sun, 15 Oct 2017 21:44:29 +0200
ludo@gnu.org (Ludovic Courtès) wrote:
> > +(define-public emacs-org-contrib
> > + (package
> > + (inherit emacs-org)
> > + (name "emacs-org-contrib")
> > + (source (origin
> > + (method url-fetch)
> > + (uri (string-append "http://orgmode.org/elpa/org-plus-contrib-"
> > + (package-version emacs-org) ".tar"))
> > + (sha256
> > + (base32
> > + "1ya4kah8kg13ka3gpsw8hn6y8358843g986p1bgw5w77n9bgbwsl"))))
> > + (arguments
> > + `(#:phases
> > + (modify-phases %standard-phases
> > + (add-after 'install 'delete-org-files
> > + (lambda* (#:key inputs outputs #:allow-other-keys)
> > + (use-modules (ice-9 ftw))
>
> Please use #:modules instead of this inner ‘use-modules’ form (it has
> wacky semantic and could be deprecated in the future.)
>
> > + (let ((out (assoc-ref outputs "out")))
> > + (for-each
> > + (lambda (file)
> > + (if (and (not (string-prefix? "." file))
> > + (file-exists? file))
> > + (delete-file
> > + (string-append
> > + out
> > + "/share/emacs/site-lisp/guix.d/org-contrib-"
> > + ,(package-version emacs-org)
> > + "/"
> > + file))))
> > + (scandir
> > + (string-append
> > + (assoc-ref inputs "emacs-org")
> > + "/share/emacs/site-lisp/guix.d/org-"
> > + ,(package-version emacs-org))))))))))
>
> For clarity, what about first buildign up the list of files to delete,
> and then actually deleting them?
>
> (let* (…
> (org+contrib (map basename (find-files out)))
> (org (map basename (find-files org)))
> (duplicates (lset-intersection string=? org+contrib org)))
> (with-directory-excursion (string-append out …)
> (for-each delete-file duplicates))
> #t)
>
> WDYT?
That is nice :) I've attached an updated patch.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-Add-emacs-org-contrib.patch --]
[-- Type: text/x-patch, Size: 2739 bytes --]
From 43ad9a4e6db6f4f94d2b2f63cbd9b729f5d4e607 Mon Sep 17 00:00:00 2001
From: Christopher Baines <mail@cbaines.net>
Date: Wed, 11 Oct 2017 14:46:47 +0100
Subject: [PATCH] gnu: Add emacs-org-contrib.
* gnu/packages/emacs.scm (emacs-org-contrib): New variable.
---
gnu/packages/emacs.scm | 43 +++++++++++++++++++++++++++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 7661855a8..6e9c2a19d 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -4099,6 +4099,49 @@ also is an authoring system with unique support for literate programming and
reproducible research.")
(license license:gpl3+)))
+(define-public emacs-org-contrib
+ (package
+ (inherit emacs-org)
+ (name "emacs-org-contrib")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "http://orgmode.org/elpa/org-plus-contrib-"
+ (package-version emacs-org) ".tar"))
+ (sha256
+ (base32
+ "1ya4kah8kg13ka3gpsw8hn6y8358843g986p1bgw5w77n9bgbwsl"))))
+ (arguments
+ `(#:modules ((guix build emacs-build-system)
+ (guix build utils)
+ (guix build emacs-utils)
+ (ice-9 ftw)
+ (srfi srfi-1))
+ #:phases
+ (modify-phases %standard-phases
+ (add-after 'install 'delete-org-files
+ (lambda* (#:key inputs outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (org (assoc-ref inputs "emacs-org"))
+ (contrib-files
+ (map basename (find-files out)))
+ (org+contrib-files
+ (map basename (find-files org)))
+ (duplicates (lset-intersection
+ string=? contrib-files org+contrib-files)))
+ (with-directory-excursion
+ (string-append
+ out "/share/emacs/site-lisp/guix.d/org-contrib-"
+ ,(package-version emacs-org))
+ (for-each delete-file duplicates))))))))
+ (propagated-inputs
+ `(("emacs-org" ,emacs-org)))
+ (synopsis "Contributed packages to Org-mode")
+ (description "Org is an Emacs mode for keeping notes, maintaining TODO
+lists, and project planning with a fast and effective plain-text system.
+
+This package is equivilent to org-plus-contrib, but only includes additional
+files that you would find in @file{contrib/} from the git repository.")))
+
(define-public emacs-flx
(package
(name "emacs-flx")
--
2.14.2
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]
next prev parent reply other threads:[~2017-10-15 20:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 5:45 [bug#28805] [PATCH] gnu: Add emacs-org-plus-contrib Christopher Baines
2017-10-13 21:42 ` Ludovic Courtès
2017-10-15 19:05 ` Christopher Baines
2017-10-15 19:44 ` Ludovic Courtès
2017-10-15 20:11 ` Christopher Baines [this message]
2017-10-16 7:27 ` Ludovic Courtès
2017-10-16 7:40 ` bug#28805: " Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171015211123.08bbae84@cbaines.net \
--to=mail@cbaines.net \
--cc=28805@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.