From: Christopher Baines <mail@cbaines.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 28787-done@debbugs.gnu.org
Subject: bug#28787: [PATCH 2/2] emacs-build-system: Change how patch-el-files substitutes commands.
Date: Sun, 15 Oct 2017 19:09:07 +0100 [thread overview]
Message-ID: <20171015190907.6053e529@cbaines.net> (raw)
In-Reply-To: <87wp3yybdk.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 824 bytes --]
On Fri, 13 Oct 2017 23:40:55 +0200
ludo@gnu.org (Ludovic Courtès) wrote:
> Christopher Baines <mail@cbaines.net> skribis:
>
> > Previously the regex would match from /bin/ to a closing quote. However, this
> > is greedy, so will match up until the last ". This causes problems when there
> > are several quotes on the same line, for example:
> >
> > org-effectiveness.el:
> > 196: (call-process "/bin/bash" nil t nil "-c" strplot)
> >
> > Therefore, change . to \S so that it doesn't include whitespace
> > characters. Changing to a lazy quantifier would be an option, if that were
> > supported.
> >
> > * guix/build/emacs-build-system.scm (patch-el-files): Change the regular
> > expression used.
>
> Good catch, LGTM!
Great :) I've now pushed the updated version of these two patches.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]
next prev parent reply other threads:[~2017-10-15 18:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 14:40 [bug#28787] [PATCH] emacs-build-system: Improve command patching Christopher Baines
2017-10-11 14:42 ` [bug#28787] [PATCH 1/2] emacs-build-system: Handle missing programs when patching Christopher Baines
2017-10-11 14:42 ` [bug#28787] [PATCH 2/2] emacs-build-system: Change how patch-el-files substitutes commands Christopher Baines
2017-10-13 21:40 ` Ludovic Courtès
2017-10-15 18:09 ` Christopher Baines [this message]
2017-10-13 21:40 ` [bug#28787] [PATCH 1/2] emacs-build-system: Handle missing programs when patching Ludovic Courtès
2017-10-15 18:06 ` Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171015190907.6053e529@cbaines.net \
--to=mail@cbaines.net \
--cc=28787-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.