From: Thomas Danckaert <post@thomasdanckaert.be>
To: mbakke@fastmail.com
Cc: 28616@debbugs.gnu.org
Subject: [bug#28616] disable failing bluez test
Date: Wed, 11 Oct 2017 18:10:58 +0200 (CEST) [thread overview]
Message-ID: <20171011.181058.1825950437807455612.post@thomasdanckaert.be> (raw)
In-Reply-To: <877ew28yw8.fsf@fastmail.com>
[-- Attachment #1: Type: Text/Plain, Size: 1011 bytes --]
From: Marius Bakke <mbakke@fastmail.com>
Subject: Re: [bug#28616] disable failing bluez test
Date: Tue, 10 Oct 2017 23:40:39 +0200
> Thomas Danckaert <post@thomasdanckaert.be> writes:
>
>> From: Marius Bakke <mbakke@fastmail.com>
>> Subject: Re: [bug#28616] disable failing bluez test
>> Date: Tue, 03 Oct 2017 23:50:56 +0200
>>
>>> I think we should apply the patch regardless (on 'core-updates'), with a
>>> link to the upstream discussion. IMO it's more important to be able to
>>> build from source regardless of hardware, than running this one unit
>>> test. What do you think?
>>
>> I agree.
>>
>> I'll push this to core-updates then.
>
> On second thought, "bluez" is currently failing on armhf, seemingly due
> to the original patch: <https://hydra.gnu.org/build/2304811/nixlog/4/raw>
I believe attached patch does the job for master, just touching armhf
and leaving other architectures alone. I tested it by replacing
armhf-linux with x86_64-linux, and then it skips the test ...
WDYT?
Thomas
[-- Attachment #2: 0001-WIP-fix-bluez.patch --]
[-- Type: Text/X-Patch, Size: 1880 bytes --]
From 89eb8efeb650d53085fa36f42b5615f6cf4717b6 Mon Sep 17 00:00:00 2001
From: Thomas Danckaert <thomas.danckaert@gmail.com>
Date: Wed, 11 Oct 2017 18:05:24 +0200
Subject: [PATCH] WIP fix bluez.
---
gnu/packages/linux.scm | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 8ef7a105d..34230cd15 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -3049,6 +3049,16 @@ Bluetooth audio output devices like headphones or loudspeakers.")
(string-append "--with-udevdir=" out "/lib/udev")))
#:phases
(modify-phases %standard-phases
+ ,@(if (string=? (%current-system) "armhf-linux")
+ ;; This test fails unpredictably.
+ ;; TODO: skip it for all architectures.
+ `((add-before 'check 'skip-wonky-test
+ (lambda _
+ (substitute* "unit/test-gatt.c"
+ (("tester_init\\(&argc, &argv\\);") "return 77;"))
+ #t)))
+ `())
+
(add-after 'install 'post-install
(lambda* (#:key inputs outputs #:allow-other-keys)
(let* ((out (assoc-ref outputs "out"))
@@ -3067,12 +3077,7 @@ Bluetooth audio output devices like headphones or loudspeakers.")
(string-append out "/lib/udev/hid2hci --method"))
(("/sbin/udevadm")
(string-append (assoc-ref inputs "eudev") "/bin/udevadm")))
- #t))))
-
- ;; FIXME: Skip one test that segfaults on ARM.
- ,@(if (string=? (%current-system) "armhf-linux")
- '(#:make-flags '("XFAIL_TESTS=unit/test-gatt"))
- '())))
+ #t))))))
(native-inputs
`(("pkg-config" ,pkg-config)
("gettext" ,gettext-minimal)))
--
2.14.2
next prev parent reply other threads:[~2017-10-11 16:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 7:21 [bug#28616] disable failing bluez test Thomas Danckaert
2017-09-27 19:30 ` Marius Bakke
2017-09-27 20:59 ` Thomas Danckaert
2017-09-28 6:42 ` Thomas Danckaert
2017-10-01 10:02 ` Thomas Danckaert
2017-10-03 21:50 ` Marius Bakke
2017-10-04 18:04 ` Thomas Danckaert
2017-10-10 21:40 ` Marius Bakke
2017-10-11 6:52 ` Thomas Danckaert
2017-10-11 16:10 ` Thomas Danckaert [this message]
2017-10-11 16:23 ` Marius Bakke
2017-10-11 19:53 ` Thomas Danckaert
2017-10-07 19:53 ` bug#28616: " Thomas Danckaert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171011.181058.1825950437807455612.post@thomasdanckaert.be \
--to=post@thomasdanckaert.be \
--cc=28616@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.