all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Thomas Danckaert <post@thomasdanckaert.be>
To: mail@cbaines.net, 28660-done@debbugs.gnu.org
Cc: 28660@debbugs.gnu.org
Subject: bug#28660: [PATCH] gnu: python-numpy: Give sh store location instead of setting $SHELL.
Date: Wed, 04 Oct 2017 14:12:27 +0200 (CEST)	[thread overview]
Message-ID: <20171004.141227.1558332285266180058.post@thomasdanckaert.be> (raw)
In-Reply-To: <20171004084944.16af59c8@cbaines.net>

From: Christopher Baines <mail@cbaines.net>
Subject: Re: [bug#28660] [PATCH] gnu: python-numpy: Give sh store 
location instead of setting $SHELL.
Date: Wed, 4 Oct 2017 08:49:44 +0100

> Sorry Thomas, ignore what I originally said. I thought from reading 
> the
> patch that this was patching numpy to use /bin/sh . Now after 
> building
> it and looking at the resulting files, I can see that it makes the
> default use bash from the store. Which was exactly what I was
> suggesting, but you were already doing that.
>
> With this new, hopefully more correct interpretation, this patch 
> looks
> fine to me :)

Yes, that's the purpose exactly :)  I've slightly reworded the commit 
message & comment to hopefully make it less confusing, and pushed.

Thanks for taking a look!

Thomas

      reply	other threads:[~2017-10-04 12:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-01 12:44 [bug#28660] [PATCH] gnu: python-numpy: Give sh store location instead of setting $SHELL Thomas Danckaert
2017-10-04  6:30 ` Christopher Baines
2017-10-04  7:04   ` Thomas Danckaert
2017-10-04  7:49     ` Christopher Baines
2017-10-04 12:12       ` Thomas Danckaert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171004.141227.1558332285266180058.post@thomasdanckaert.be \
    --to=post@thomasdanckaert.be \
    --cc=28660-done@debbugs.gnu.org \
    --cc=28660@debbugs.gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.