From: Christopher Baines <mail@cbaines.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 28288@debbugs.gnu.org
Subject: [bug#28288] [PATCH 1/5] vm: Add support for registering closures to make-iso9660-image.
Date: Sun, 10 Sep 2017 11:45:32 +0100 [thread overview]
Message-ID: <20170910114532.58628283@cbaines.net> (raw)
In-Reply-To: <87wp5c0xqr.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1951 bytes --]
On Wed, 06 Sep 2017 15:20:44 +0200
ludo@gnu.org (Ludovic Courtès) wrote:
> Christopher Baines <mail@cbaines.net> skribis:
>
> > On Tue, 05 Sep 2017 15:17:32 +0200
> > ludo@gnu.org (Ludovic Courtès) wrote:
> >
> >> Hi!
> >>
> >> Christopher Baines <mail@cbaines.net> skribis:
> >>
> >> > This mimics the functionality in the root-partition-initializer
> >> > used in creating the QEMU image. This helps when trying to run
> >> > guix system init from the generated ISO image.
> >> >
> >> > * gnu/build/vm.scm (make-iso9660-image): Add support for
> >> > registering closures.
> >>
> >> [...]
> >>
> >> > + (when register-closures?
> >> > + (display "registering closures...\n")
> >> > + (for-each (lambda (closure)
> >> > + (register-closure
> >> > + "/tmp/root"
> >> > + (string-append "/xchg/" closure)
> >> > + #:deduplicate? #f))
> >> > + closures))
> >>
> >> Was there any specific reason for #:deduplicate? #f here?
> >
> > Yep, the image creation process fails if this is not specified.
> >
> > error: cannot link
> > `/tmp/root/gnu/store/.links/1wj8bqv0ygz606a0day0gk7w37prsnbg5z2im2yf025r0y6lqfs0'
> > to
> > `/tmp/root/gnu/store/00lgsgxvv1hfhl22yqmzsa3lrs5qa9my-firmware/lib/firmware/b43-open':
> > Invalid cross-device link
>
> Hmm, OK. Looks like it’s trying to deduplicate between /tmp/root and
> some other store. (Or are we using a bind mount here?)
I think there is a bind mount in use here, so maybe that has something
to do with it.
> > There is probably another way around this though. I'm not sure what
> > impact skipping the deduplication has on the size of the image.
>
> It probably doesn’t matter much, so it’s not a blocker IMO.
>
> Maybe leave an XXX comment mentioning the cross-device link issue.
Yep, I'll put in a comment :)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]
prev parent reply other threads:[~2017-09-10 10:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 6:17 [bug#28288] [PATCH] Test and fix the ISO Image Installer Christopher Baines
2017-08-30 6:20 ` [bug#28288] [PATCH 1/2] tests: Add test for installing from an ISO Image Christopher Baines
2017-08-30 6:20 ` [bug#28288] [PATCH 2/2] WIP Christopher Baines
2017-08-30 6:31 ` Christopher Baines
2017-08-30 8:38 ` Danny Milosavljevic
2017-08-30 22:56 ` Christopher Baines
2017-08-31 13:04 ` Danny Milosavljevic
2017-08-31 21:47 ` Christopher Baines
2017-08-30 18:26 ` Danny Milosavljevic
2017-09-03 10:50 ` [bug#28288] [PATCH 1/5] vm: Add support for registering closures to make-iso9660-image Christopher Baines
2017-09-03 10:50 ` [bug#28288] [PATCH 2/5] vm: Create /mnt in the generated ISO image in make-iso9660-image Christopher Baines
2017-09-05 12:58 ` Danny Milosavljevic
2017-09-03 10:50 ` [bug#28288] [PATCH 3/5] vm: Add support for registering closures to iso9660-image Christopher Baines
2017-09-05 12:57 ` Danny Milosavljevic
2017-09-03 10:50 ` [bug#28288] [PATCH 4/5] vm: Call iso9660-image with #:register-closures? as #t Christopher Baines
2017-09-05 12:56 ` Danny Milosavljevic
2017-09-05 13:18 ` Ludovic Courtès
2017-09-03 10:50 ` [bug#28288] [PATCH 5/5] tests: Add test for installing from an ISO Image Christopher Baines
2017-09-03 10:58 ` Christopher Baines
2017-09-05 13:18 ` Ludovic Courtès
2017-09-06 7:46 ` bug#28288: " Christopher Baines
2017-09-05 13:17 ` [bug#28288] [PATCH 1/5] vm: Add support for registering closures to make-iso9660-image Ludovic Courtès
2017-09-06 7:05 ` Christopher Baines
2017-09-06 13:20 ` Ludovic Courtès
2017-09-10 10:45 ` Christopher Baines [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170910114532.58628283@cbaines.net \
--to=mail@cbaines.net \
--cc=28288@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.