all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 27593@debbugs.gnu.org
Subject: bug#27593: [PATCH] gnu: groff: Make build reproducible.
Date: Mon, 10 Jul 2017 21:28:45 +0200	[thread overview]
Message-ID: <20170710212845.587fd165@scratchpost.org> (raw)
In-Reply-To: <87r2xo9kmj.fsf@fastmail.com>

Hi Marius,

On Mon, 10 Jul 2017 21:07:00 +0200
Marius Bakke <mbakke@fastmail.com> wrote:

> Danny Milosavljevic <dannym@scratchpost.org> writes:
> 
> > * gnu/packages/groff.scm (groff)[arguments]: Add phase "setenv".  
> 
> What does this add to the previous patch? Can you add a comment in the
> code explaining what it's for?

It replaces the previous patch by using a new patched-ghostscript feature:
- ghostscript can now be instructed to not print the problematic parts (timestamps in headers, UUIDs in headers) that were the original cause of the "ever-changing PDFs" problem.

The previous approach was fighting the symptoms, where every time a problem appeared in one of the outputs, I'd patch it somewhere else so that, if it did make it to ghostscript, ghostscript would put fake timestamps and would derive UUIDs from them - which upstream recommended we should definitely not do.

That was really not scalable or sane.

Also, the original ghostscript states that they are printing the current system date into PDFs (rather than, say, the input file mtime), against better judgement, for compatibility.  Just no.

So this patch prevents ghostscript from putting the timestamps or the document UUIDs into the PDFs in the first place (I don't mean it puts a fake one there now - I mean it leaves the fields off entirely).  Much simpler.

I'll add a comment.

  reply	other threads:[~2017-07-10 19:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-06  0:54 bug#27593: groff build is not reproducible Danny Milosavljevic
2017-07-06  1:01 ` bug#27593: [PATCH] gnu: groff: Remove timestamps Danny Milosavljevic
2017-07-06  1:47 ` bug#27593: [PATCH v2] " Danny Milosavljevic
2017-07-09 13:00   ` Marius Bakke
2017-07-09 19:51     ` Ludovic Courtès
2017-07-09 21:27       ` bug#27593: [PATCH v3] " Danny Milosavljevic
2017-07-09 21:55         ` Marius Bakke
2017-07-10  9:05           ` Ludovic Courtès
2017-07-10 10:40             ` Danny Milosavljevic
2017-07-10 16:37 ` bug#27593: [PATCH] gnu: groff: Make build reproducible Danny Milosavljevic
2017-07-10 19:07   ` Marius Bakke
2017-07-10 19:28     ` Danny Milosavljevic [this message]
2017-07-11  9:31   ` Ludovic Courtès
2017-09-09 20:31     ` Ludovic Courtès
2017-09-09 21:17       ` Danny Milosavljevic
2017-09-10 13:13         ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170710212845.587fd165@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=27593@debbugs.gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.