From: "Ludovic Courtès" <ludo@gnu.org>
To: 27271@debbugs.gnu.org
Subject: bug#27271: [PATCH 3/4] guix package: Always upgrade packages that have propagated inputs.
Date: Wed, 7 Jun 2017 11:25:05 +0200 [thread overview]
Message-ID: <20170607092506.20844-3-ludo@gnu.org> (raw)
In-Reply-To: <20170607092506.20844-1-ludo@gnu.org>
* guix/scripts/package.scm (transaction-upgrade-entry): Always upgrade
packages that have propagated inputs.
---
guix/scripts/package.scm | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/guix/scripts/package.scm b/guix/scripts/package.scm
index f050fad97..4de95869f 100644
--- a/guix/scripts/package.scm
+++ b/guix/scripts/package.scm
@@ -298,7 +298,10 @@ synopsis or description matches all of REGEXPS."
((=)
(let ((candidate-path (derivation->output-path
(package-derivation (%store) pkg))))
- (if (string=? path candidate-path)
+ ;; XXX: When there are propagated inputs, assume we need to
+ ;; upgrade the whole entry.
+ (if (and (string=? path candidate-path)
+ (null? (package-propagated-inputs pkg)))
transaction
(manifest-transaction-install-entry
(package->manifest-entry pkg output)
--
2.13.0
next prev parent reply other threads:[~2017-06-07 9:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 9:22 bug#27271: [PATCH 0/4] Catch collisions at profile creation time Ludovic Courtès
2017-06-07 9:25 ` bug#27271: [PATCH 1/4] profiles: Represent propagated inputs as manifest entries Ludovic Courtès
2017-06-07 9:25 ` bug#27271: [PATCH 2/4] profiles: Manifest entries keep a reference to their parent entry Ludovic Courtès
2017-06-07 9:25 ` Ludovic Courtès [this message]
2017-06-07 9:25 ` bug#27271: [PATCH 4/4] profiles: Catch and report collisions in the profile Ludovic Courtès
2017-06-09 1:42 ` bug#27271: [PATCH 0/4] Catch collisions at profile creation time Ricardo Wurmus
2017-06-09 9:41 ` Ludovic Courtès
2017-06-09 20:32 ` Marius Bakke
2017-06-10 13:39 ` bug#27271: Avoiding ‘propagated-inputs’ for Python dependencies Ludovic Courtès
2017-06-17 8:40 ` [bug#27271] " Hartmut Goebel
2017-06-17 9:00 ` Hartmut Goebel
2017-06-17 9:28 ` [bug#27271] [PATCH 0/4] Catch collisions at profile creation time Ricardo Wurmus
2017-06-17 12:30 ` Ludovic Courtès
2017-06-21 9:07 ` bug#27271: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170607092506.20844-3-ludo@gnu.org \
--to=ludo@gnu.org \
--cc=27271@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.