all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Kei Kebreau <kei@openmailbox.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: windowmaker: Fix invocation of 'wmsetbg'.
Date: Fri, 9 Dec 2016 20:02:31 -0500	[thread overview]
Message-ID: <20161210010231.GA20285@jasmine> (raw)
In-Reply-To: <87zilr692s.fsf@openmailbox.org>

[-- Attachment #1: Type: text/plain, Size: 1219 bytes --]

On Wed, Oct 26, 2016 at 12:14:03AM -0400, Kei Kebreau wrote:
> Marius Bakke <mbakke@fastmail.com> writes:
> 
> > Kei Kebreau <kei@openmailbox.org> writes:
> >
> >> This patch allows Window Maker to run wmsetbg properly instead of
> >> showing an error as it has been.
> >> From a113116da6f9f6574e9fde12e69a9d3acdc87769 Mon Sep 17 00:00:00 2001
> >> From: Kei Kebreau <kei@openmailbox.org>
> >> Date: Sun, 23 Oct 2016 13:50:05 -0400
> >> Subject: [PATCH] gnu: windowmaker: Fix invocation of 'wmsetbg'.
> >>
> >> * gnu/packages/gnustep.scm (windowmaker)[arguments]: Add substitution of
> >> 40-character limit with a 107-character limit.
> >> ---
> >>  gnu/packages/gnustep.scm | 8 +++++++-
> >>  1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > I haven't tested this, but the diff looks reasonable. Good catch. Any
> > chance you can submit this upstream as well?
> 
> I could bring it up, but I'm not so sure that it would be a change worth
> considering. The Window Maker mailing list is very low volume, and no
> one seems to have complained about this.

I think it's a safe change, but I also think we should always let
upstream know when we are modifying string-handling code in C.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      parent reply	other threads:[~2016-12-10  1:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-25 17:46 [PATCH] gnu: windowmaker: Fix invocation of 'wmsetbg' Kei Kebreau
2016-10-26  3:07 ` Marius Bakke
2016-10-26  4:14   ` Kei Kebreau
2016-12-09 21:09     ` Kei Kebreau
2016-12-09 21:33       ` Marius Bakke
2016-12-10  3:12         ` Kei Kebreau
2016-12-10  1:02     ` Leo Famulari [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161210010231.GA20285@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=kei@openmailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.