all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andreas Enge <andreas@enge.fr>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org, Danny Milosavljevic <dannym+a@scratchpost.org>
Subject: Re: [PATCH] gnu: Add perl-db_file.
Date: Tue, 26 Jul 2016 22:48:37 +0200	[thread overview]
Message-ID: <20160726204837.GA14094@solar> (raw)
In-Reply-To: <20160726210138.6b90aef7@scratchpost.org>

Hello,

On Tue, Jul 26, 2016 at 09:01:38PM +0200, Danny Milosavljevic wrote:
> Yeah, I thought about it but decided against it - there are very few options in that file, substitute* can't substitute entire lines (or only at the beginning of the line) or entire words (so it's not safe), the user is supposed to set PREFIX and HASH (it's just a coincidence we didn't have to change them) and if we did that then new versions of the package could sneak in new options we wouldn't notice but we should have changed. Better for it to fail instead of silently doing something strange.

well, substitute* is closer to a diff - it makes it easy to see what actually
changes. And I would make the converse argument of you - for the next version,
if more things change (an option is added to the file, for instance), then
the substitute* still has a chance to get a working package. Imagine that
someone without knowledge of the package might be the one to update it, for
instance.

I pushed with tiny changes to the description.

Thanks!

Andreas

      parent reply	other threads:[~2016-07-26 20:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-26 15:35 [PATCH] gnu: Add perl-db_file Danny Milosavljevic
     [not found] ` <20160726183531.GA11804@solar>
2016-07-26 19:01   ` Danny Milosavljevic
2016-07-26 19:05     ` [PATCH v2] " Danny Milosavljevic
2016-07-26 20:48     ` Andreas Enge [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160726204837.GA14094@solar \
    --to=andreas@enge.fr \
    --cc=dannym+a@scratchpost.org \
    --cc=dannym@scratchpost.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.