all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Alex Griffin <a@ajgrf.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add reptyr.
Date: Sat, 9 Jul 2016 14:20:35 -0400	[thread overview]
Message-ID: <20160709182035.GB2010@jasmine> (raw)
In-Reply-To: <1468006716.1010694.660917729.687C408B@webmail.messagingengine.com>

On Fri, Jul 08, 2016 at 02:38:36PM -0500, Alex Griffin wrote:
> This patch adds reptyr, a tool for reparenting a running program to a
> new terminal. I put it in screen.scm because it is usually used to move
> a process into a screen or tmux session.

Thank you, I will use this :)

> Also somewhat related, I think the file tmux.scm should merge with
> screen.scm.

If we are considering moving these packages around, I think that
screen.scm and tmux.scm should go into terminals.scm. But, I also think
that this patch should not be held up by that discussion.

> +    (arguments
> +     '(#:tests? #f

Why skip the tests? We prefer to run tests whenever possible. Otherwise,
please add a comment explaining why. For example "No test suite."

> +       #:phases (alist-delete 'configure %standard-phases)))

This is short and sweet, but we like to use modify-phases for
consistency.

> +    (description
> +     "reptyr is a utility for taking an existing running program and attaching
> +it to a new terminal.  Started a long-running process over ssh, but have to
> +leave and don't want to interrupt it?  Just start a screen, use reptyr to grab
> +it, and then kill the ssh session and head on home.")

We should capitalize the beginning of the description, and I would also
wrap 'ssh' and 'screen' in texinfo:

@code{ssh}
@code{screen}

  reply	other threads:[~2016-07-09 18:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-08 19:38 [PATCH] gnu: Add reptyr Alex Griffin
2016-07-09 18:20 ` Leo Famulari [this message]
2016-07-12 20:17   ` Alex Griffin
2016-07-17  0:02     ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160709182035.GB2010@jasmine \
    --to=leo@famulari.name \
    --cc=a@ajgrf.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.