From: Leo Famulari <leo@famulari.name>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] Add syslog.scm and rsyslog.
Date: Mon, 28 Mar 2016 12:09:17 -0400 [thread overview]
Message-ID: <20160328160917.GA7724@jasmine> (raw)
In-Reply-To: <20160319182524.64f7f9b2@scratchpost.org>
On Sat, Mar 19, 2016 at 06:25:24PM +0100, Danny Milosavljevic wrote:
> Hi,
>
> this adds gnu/packages/syslog.scm and rsyslog.
Hi, thanks for this, sorry for the delayed review!
> If someone knowledgeable about which license text is which license can check the FIXMEs that would be nice.
My approach to checking licenses is to do a web search for some phrase
from the license, and then check the package's license text against the
results of the search.
Also, these are some good resources:
https://www.gnu.org/licenses/license-list
www.gnu.org/licenses/license-list.html
>
> That said, it seems inetutils also contains a syslogd (it also auto-starts; I didn't see it before) - so not sure how useful having another syslog is now.
If rsyslog is a different program, then it's useful to someone!
> ---
> gnu/packages/syslog.scm | 110 ++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 110 insertions(+)
> create mode 100644 gnu/packages/syslog.scm
For your revisions, please submit each package as its own patch. You can
read `git log` to learn the conventions for commit messages.
Also, please remember to run `./pre-inst-env guix lint` on each
package. Most of the changes that need to made to these packages will be
described by `guix lint`.
[...]
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2013 Andreas Enge <andreas@enge.fr>
> +;;; Copyright © 2014, 2015 Mark H Weaver <mhw@netris.org>
Don't forget to add a copyright line for yourself.
> +(define-public libfastjson
[...]
> + (license license:gpl2+))) ; FIXME actually MIT. Which one?
In the links I shared above, refer to the Expat and X11 licenses to see
which "MIT" license this is.
> +(define-public liblogging
[...]
> + (arguments `(#:configure-flags '("--disable-journal" ; to avoid libsystemd-journal
> +)))
If you leave the journal support enabled, does the program break when
journald is absent? Users on systemd-based systems may want to use
liblogging :)
> +(define-public rsyslog
[...]
> + (inputs `(("libestr" ,libestr)
> + ("libfastjson" ,libfastjson)
> + ("zlib" ,zlib)
> + ("util-linux" ,util-linux)
Since util-linux is a "grab bag" of unrelated programs, I like to say in
what it's being used for. There are some examples of this in
gnu/packages.
Can you submit a revised patch set?
prev parent reply other threads:[~2016-03-28 16:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-19 17:25 [PATCH] Add syslog.scm and rsyslog Danny Milosavljevic
2016-03-28 16:09 ` Leo Famulari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160328160917.GA7724@jasmine \
--to=leo@famulari.name \
--cc=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.