From: Roel Janssen <roel@gnu.org>
To: 39013@debbugs.gnu.org
Subject: [bug#39013] [PATCH] gnu: Add abseil-cpp.
Date: Tue, 07 Jan 2020 16:07:21 +0100 [thread overview]
Message-ID: <1f9fb8236e2a652ea4389c8d18b663307b275153.camel@gnu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 537 bytes --]
Dear Guix,
The following patch adds abseil-cpp. I want to add it because it seems
to be a dependency of tensorflow-1.15.0 (which I am trying to update
to).
There are two not-so-perfect things with the patch:
1. I had to use the latest Git commit because it adds bits to build
shared libraries.
2. I disabled the tests because it attempts to download "googletest".
I tried modifying the build system to use "googletest" from Guix but
that wasn't succesful.
Nevertheless, I hope this patch is acceptable.
Kind regards,
Roel Janssen
[-- Attachment #2: 0001-gnu-Add-abseil-cpp.patch --]
[-- Type: text/x-patch, Size: 2297 bytes --]
From 06ed0284561463c087ec0f16f9c35fc7926f22df Mon Sep 17 00:00:00 2001
From: Roel Janssen <roel@gnu.org>
Date: Tue, 7 Jan 2020 16:02:28 +0100
Subject: [PATCH] gnu: Add abseil-cpp.
* gnu/packages/machine-learning.scm (abseil-cpp): New variable.
---
gnu/packages/machine-learning.scm | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/gnu/packages/machine-learning.scm b/gnu/packages/machine-learning.scm
index 719401d69a..91cc4fe091 100644
--- a/gnu/packages/machine-learning.scm
+++ b/gnu/packages/machine-learning.scm
@@ -1316,6 +1316,34 @@ mile of distributed computing to connect devices, mobile applications and
browsers to backend services.")
(license license:asl2.0)))
+(define-public abseil-cpp
+ ;; We use this commit because it contains changes to the build system to
+ ;; allow building shared libraries.
+ (let ((commit "a048203a881f11f4b7b8df5fb563aec85522f8db"))
+ (package
+ (name "abseil-cpp")
+ (version (string-append "20190808-" (string-take commit 7)))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/abseil/abseil-cpp.git")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "13v3bkfyhrcl9am0jcz4cfbfc5rn3acm9z4wm01pn36vcgvw2l4s"))))
+ (build-system cmake-build-system)
+ (arguments `(#:configure-flags (list "-DBUILD_SHARED_LIBS=ON")
+ #:tests? #f)) ; Tests attempt to download googletest.
+ (home-page "https://abseil.io")
+ (synopsis "Augmented C++ standard library")
+ (description "Abseil is an open-source collection of C++ library code
+designed to augment the C++ standard library. The Abseil library code is
+collected from Google's own C++ code base, has been extensively tested and
+used in production, and is the same code we depend on in our daily coding
+lives.")
+ (license license:asl2.0))))
+
;; Note that Tensorflow includes a "third_party" directory, which seems to not
;; only contain modified subsets of upstream library source code, but also
;; adapter headers provided by Google (such as the fft.h header, which is not
--
2.17.1
next reply other threads:[~2020-01-07 15:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 15:07 Roel Janssen [this message]
2020-01-09 21:53 ` [bug#39013] [PATCH] gnu: Add abseil-cpp Ludovic Courtès
2020-01-10 19:23 ` Roel Janssen
2020-01-15 20:53 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f9fb8236e2a652ea4389c8d18b663307b275153.camel@gnu.org \
--to=roel@gnu.org \
--cc=39013@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.