From: Skyler Ferris via Guix-patches via <guix-patches@gnu.org>
To: Philip McGrath <philip@philipmcgrath.com>, 70065@debbugs.gnu.org
Subject: [bug#70065] [PATCH 2/6] gnu: racket: Update to 8.12.
Date: Sat, 30 Mar 2024 14:35:06 +0000 [thread overview]
Message-ID: <1b795f9e-bcef-4b14-8ae3-0b69c79d51f9@protonmail.com> (raw)
In-Reply-To: <6b2db55dfe43979e28bd85d2999919419d56dd84.1711688274.git.philip@philipmcgrath.com>
On 3/28/24 22:18, Philip McGrath wrote:
> +(define chez-configure
> + ;; The custom Chez 'configure' script doesn't allow unrecognized flags, such
> + ;; as those automatically added by `gnu-build-system`. This replacement
> + ;; phase uses only the explicitly provided `#:configure-flags`.
> + #~(lambda* (#:key inputs (configure-flags '()) out-of-source?
> + #:allow-other-keys)
> + (let* ((abs-srcdir (getcwd))
> + (srcdir (if out-of-source?
> + (string-append "../" (basename abs-srcdir))
> + ".")))
> + (format #t "source directory: ~s (relative from build: ~s)~%"
> + abs-srcdir srcdir)
> + (when out-of-source?
> + (begin
> + (mkdir "../build")
> + (chdir "../build")))
> + (format #t "build directory: ~s~%" (getcwd))
> + (format #t "configure flags: ~s~%" configure-flags)
> + (apply invoke
> + (string-append srcdir "/configure")
> + configure-flags))))
> +
Are the format statements supposed to be here or are they left over from
debugging?
> + ;; Building the documentation requires stex and a running scheme.
> + ;; TODO: improve cross support upstream.
I believe this comment should be associated with the build-docs phase,
not the install-docs phase, correct?
Additionally, I am not too familiar with autotools, so while I did look
over it and the changes seem reasonable my perspective on that aspect of
this patch should be taken with a grain of salt.
next prev parent reply other threads:[~2024-03-30 14:36 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 5:15 [bug#70065] [PATCH 0/6] gnu: Update to Racket 8.12, Chez Scheme 10, and Zuo 1.9 Philip McGrath
2024-03-29 5:18 ` [bug#70065] [PATCH 1/6] gnu: zuo: Update to 1.9 Philip McGrath
2024-03-30 14:31 ` Skyler Ferris via Guix-patches via
2024-03-29 5:18 ` [bug#70065] [PATCH 2/6] gnu: racket: Update to 8.12 Philip McGrath
2024-03-30 14:35 ` Skyler Ferris via Guix-patches via [this message]
2024-03-30 22:10 ` Philip McGrath
2024-03-29 5:18 ` [bug#70065] [PATCH 3/6] gnu: chez-scheme: Reorganize package definitions Philip McGrath
2024-03-30 14:35 ` Skyler Ferris via Guix-patches via
2024-03-29 5:18 ` [bug#70065] [PATCH 4/6] gnu: chez-scheme: Update to 10.0.0 Philip McGrath
2024-03-30 7:56 ` Liliana Marie Prikler
2024-03-30 14:39 ` Skyler Ferris via Guix-patches via
2024-03-30 22:49 ` Philip McGrath
2024-03-31 14:35 ` Skyler Ferris via Guix-patches via
2024-03-31 15:28 ` Skyler Ferris via Guix-patches via
2024-03-31 20:17 ` Philip McGrath
2024-04-02 14:55 ` Skyler Ferris via Guix-patches via
2024-04-01 6:51 ` [bug#70065] [PATCH v2 0/8] Update to Racket 8.12, Chez Scheme 10, and Zuo 1.9 Philip McGrath
2024-04-01 6:51 ` [bug#70065] [PATCH v2 1/8] gnu: zuo: Update to 1.9 Philip McGrath
2024-04-01 6:51 ` [bug#70065] [PATCH v2 2/8] gnu: racket: Update to 8.12 Philip McGrath
2024-04-09 8:46 ` Efraim Flashner
2024-04-11 10:44 ` Ludovic Courtès
2024-04-11 12:34 ` Efraim Flashner
2024-04-01 6:51 ` [bug#70065] [PATCH v2 3/8] gnu: chez-scheme: Reorganize package definitions Philip McGrath
2024-04-01 15:40 ` Liliana Marie Prikler
2024-04-02 3:59 ` Philip McGrath
2024-04-01 6:51 ` [bug#70065] [PATCH v2 4/8] gnu: chez-scheme: Update to 10.0.0 Philip McGrath
2024-04-01 6:51 ` [bug#70065] [PATCH v2 5/8] gnu: Deprecate chez-scheme-for-system.in favor of chez-scheme Philip McGrath
2024-04-01 6:51 ` [bug#70065] [PATCH v2 6/8] gnu: Fix uses of deprecated chez-scheme-for-system Philip McGrath
2024-04-01 15:41 ` Liliana Marie Prikler
2024-04-01 6:51 ` [bug#70065] [PATCH v2 7/8] gnu: chez-scheme: Update and simplify machine-type handling Philip McGrath
2024-04-01 15:45 ` Liliana Marie Prikler
2024-04-02 3:59 ` Philip McGrath
2024-04-01 6:51 ` [bug#70065] [PATCH v2 8/8] gnu: chez-scheme: Bootstrap from source Philip McGrath
2024-04-11 10:55 ` bug#70065: [PATCH v2 0/8] Update to Racket 8.12, Chez Scheme 10, and Zuo 1.9 Ludovic Courtès
2024-03-29 5:18 ` [bug#70065] [PATCH 5/6] gnu: chez-scheme: Update and simplify machine-type handling Philip McGrath
2024-03-30 14:40 ` Skyler Ferris via Guix-patches via
2024-03-29 5:18 ` [bug#70065] [PATCH 6/6] gnu: chez-scheme: Bootstrap from source Philip McGrath
2024-03-30 14:41 ` Skyler Ferris via Guix-patches via
2024-03-30 14:28 ` [bug#70065] [PATCH 0/6] gnu: Update to Racket 8.12, Chez Scheme 10, and Zuo 1.9 Skyler Ferris via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b795f9e-bcef-4b14-8ae3-0b69c79d51f9@protonmail.com \
--to=guix-patches@gnu.org \
--cc=70065@debbugs.gnu.org \
--cc=philip@philipmcgrath.com \
--cc=skyvine@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.