From: Alexey Abramov <levenson@mmer.org>
To: "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>
Cc: Julien Lepiller <julien@lepiller.eu>,
39742@debbugs.gnu.org, Leo Famulari <leo@famulari.name>
Subject: [bug#39742] [PATCH 1/7] gnu: java-openjfx-build: Add helpful patch.
Date: Thu, 05 Mar 2020 21:10:01 +0100 [thread overview]
Message-ID: <170ac51b5a8.281d.da5dc967fe079fb386b94d5b80162893@mmer.org> (raw)
In-Reply-To: <20200305200925.31b637d4@alma-ubu>
Hi,
I have been trying to compile it so many times, so I patched the file for
easy debugging )
I traced some confusing parts of a build.gradle using gradlew ...
--verbose to translate it in Scheme.
Alexey
On March 5, 2020 19:38:40 Björn Höfling <bjoern.hoefling@bjoernhoefling.de>
wrote:
> Hi Alexey,
>
> On Sat, 22 Feb 2020 21:17:49 +0100
> Alexey Abramov <levenson@mmer.org> wrote:
>
>> * gnu/packages/java.scm: Add patch
>> * gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch:
>> New file. Allows you to run gradlew to run properly. Useful for
>> debugging. ---
>
> This sentence sounds suspicious :-)
>
> In Guix, we build everything from source. If we need a compiler,
> library, or build-tool, we build that also from source.
>
> Here, the problem is that:
>
> gradle/wrapper/gradle-wrapper.jar
>
> is a binary JAR-file included in the sources, which is used by the
> 'gradlew' script. This jar-file should not be part of the original
> sources used to to compile this package.
>
> Whenever sources contain unwanted binaries, we use 'snippets' to remove
> them before doing any further steps. You will find them in many places
> in the java.scm file, just search for 'snippet', for example in the
> package java-cisd-jhdf5.
>
> For using gradle, we need to compile gradle from sources, but this is
> very hard, there are some bootstrapping problems involed in this.
>
> So, first we should first snipp away the jar-files from the original
> java-openjfx-build package by Julien.
>
> And second, I hope you don't rely on the gradle build in any way
> here :-)
>
> Björn
>
>> gnu/packages/java.scm | 3 ++-
>> .../java-openjfx-build-get_guix_jdk_version.patch | 14
>> ++++++++++++++ 2 files changed, 16 insertions(+), 1 deletion(-)
>> create mode 100644
>> gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch
>>
>> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
>> index 9371901e1f..01541ee419 100644
>> --- a/gnu/packages/java.scm
>> +++ b/gnu/packages/java.scm
>> @@ -2355,7 +2355,8 @@ new Date();"))
>> (file-name (string-append name "-" version
>> "-checkout")) (sha256
>> (base32
>> -
>> "0yg38mwpivswccv9n96k06x3iv82i4px1a9xg9l8dswzwmfj259f"))))
>> +
>> "0yg38mwpivswccv9n96k06x3iv82i4px1a9xg9l8dswzwmfj259f"))
>> + (patches (search-patches
>> "java-openjfx-build-get_guix_jdk_version.patch")))) (build-system
>> ant-build-system) (arguments
>> `(#:jar-name "java-openjfx.jar"
>> diff --git
>> a/gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch
>> b/gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch
>> new file mode 100644 index 0000000000..214ef9949c --- /dev/null
>> +++
>> b/gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch
>> @@ -0,0 +1,14 @@ +--- a/build.gradle
>> ++++ b/build.gradle
>> +@@ -742,9 +742,9 @@
>> + if (inStream.readLine() != null) {
>> + String v = inStream.readLine();
>> + if (v != null) {
>> +- int ib = v.indexOf(" (build ");
>> ++ int ib = v.indexOf(" (guix build ");
>> + if (ib != -1) {
>> +- String ver = v.substring(ib + 8, v.size() - 1);
>> ++ String ver = v.substring(ib + 13, v.size() - 1);
>> +
>> + defineProperty("jdkRuntimeVersion", ver)
>> + defineProperty("jdkVersion",
>> jdkRuntimeVersion.split("-")[0])
next prev parent reply other threads:[~2020-03-05 20:11 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-22 20:17 [bug#39742] [PATCH 1/7] gnu: java-openjfx-build: Add helpful patch Alexey Abramov
2020-02-22 20:17 ` [bug#39744] [PATCH 2/7] gnu: java-openjfx-build: Fix indentation Alexey Abramov
2020-02-22 20:17 ` [bug#39747] [PATCH 3/7] gnu: java-openjfx-graphics: Implement a complete compilation Alexey Abramov
2020-03-04 3:00 ` Leo Famulari
2020-03-09 13:08 ` levenson
2020-03-09 12:46 ` [bug#39747] [v2] " Alexey Abramov
2020-02-22 20:17 ` [bug#39745] [PATCH 4/7] gnu: java-openjfx-swing: Add new variable Alexey Abramov
2020-03-04 3:04 ` Leo Famulari
2020-03-09 22:08 ` [bug#39741] " levenson
2020-03-09 16:15 ` [bug#39745] [v2] gnu: java-openjfx-build: Fix openjfx-swing component build for JDKu8 Alexey Abramov
2020-03-09 16:36 ` [bug#39745] [v3 1/2] " Alexey Abramov
2020-03-09 16:36 ` [bug#39745] [v3 2/2] gnu: java-openjfx-swing: Add new variable Alexey Abramov
2020-03-11 10:36 ` [bug#39745] [v4 1/2] gnu: java-openjfx-build: Fix openjfx-swing component build for JDKu8 Alexey Abramov
2020-03-11 10:36 ` [bug#39745] [v4 2/2] gnu: java-openjfx-swing: Add new variable Alexey Abramov
2020-02-22 20:17 ` [bug#39741] [PATCH 5/7] gnu: java-openjfx-swt: " Alexey Abramov
2020-03-09 16:41 ` [bug#39741] [v2] " Alexey Abramov
2020-02-22 20:17 ` [bug#39743] [PATCH 6/7] gnu: java-openjfx-controls: " Alexey Abramov
2020-03-09 16:54 ` [bug#39743] [v2] " Alexey Abramov
2020-02-22 20:17 ` [bug#39746] [PATCH 7/7] gnu: java-openjfx-web: " Alexey Abramov
2020-03-04 3:07 ` Leo Famulari
2020-03-09 22:13 ` [bug#39741] " levenson
2020-03-17 22:17 ` Tobias Geerinckx-Rice via Guix-patches via
2020-03-09 21:41 ` [bug#39746] [v2 1/2] gnu: java-openjfx-build: Prepare a patch to build openjfx-web Alexey Abramov
2020-03-09 21:41 ` [bug#39746] [v2 2/2] gnu: java-openjfx-web: Add new variable Alexey Abramov
2020-03-14 6:10 ` [bug#39746] [v3 1/2] gnu: java-openjfx-build: Prepare a patch to build openjfx-web Alexey Abramov
2020-03-14 6:10 ` [bug#39746] [v3 2/2] gnu: java-openjfx-web: Add new variable Alexey Abramov
2020-03-03 17:33 ` [bug#39742] [PATCH 1/7] gnu: java-openjfx-build: Add helpful patch levenson
2020-03-04 2:56 ` Leo Famulari
2020-03-05 20:42 ` Alexey Abramov
2020-03-05 19:09 ` Björn Höfling
2020-03-05 20:10 ` Alexey Abramov [this message]
2020-03-05 21:35 ` Björn Höfling
2020-03-08 19:40 ` [bug#39742] [v2] " Alexey Abramov
2020-03-15 18:19 ` bug#39742: " Leo Famulari
2020-03-17 21:12 ` [bug#39742] " Björn Höfling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170ac51b5a8.281d.da5dc967fe079fb386b94d5b80162893@mmer.org \
--to=levenson@mmer.org \
--cc=39742@debbugs.gnu.org \
--cc=bjoern.hoefling@bjoernhoefling.de \
--cc=julien@lepiller.eu \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.