From: Tanguy LE CARROUR <tanguy@bioneland.org>
To: Lars-Dominik Braun <lars@6xq.net>
Cc: 60240@debbugs.gnu.org
Subject: [bug#60240] [PATCH v2] gnu: Add python-3.12 and python-next.
Date: Mon, 26 Feb 2024 09:25:23 +0100 [thread overview]
Message-ID: <170893592338.2024.18126018474930945065@bioneland.org> (raw)
In-Reply-To: <ZdtJ1AU7ru7Vr2TU@noor.fritz.box>
Hi Lars,
Thanks for reviewing!
Quoting Lars-Dominik Braun (2024-02-25 15:08:20)
> > I created a brand new package definition for it, not inheriting from
> > `python-2`. I actually copied/pasted the `python-2` package definition,
> > removed what was specific to Python 2 and then copied over the things
> > specific to Python 3 from the `python-3.10` package definition.
>
> LGTM.
>
> I believe the separate tk output does not give us any benefits regarding
> closure size (any more?), because tcl and tk are both referenced from
> `out`. Can we remove those references to reduce closure size again?
Sorry, but I’m not sure to see what you mean!?
Outputs are defined for `out`, `tk` and `idle`. And I see phases to move
files to the outputs: `move-tk-inter` and `move-idle`.
What do you mean by `referenced from out`? And how would you remove such
a reference!
Sorry, I’m still new to this! 😅
> And I can also confirm test_asyncio runs out of memory on my machine
> and test_threading never finishes. We should probably investigate both,
> because they should not.
I searched in the issue list on GH, but couldn’t find anything relevant.
But there are quite a lot of issues there.
Do we have to fix this before we merge it?
> > - When I apply the patch I get whitespace errors, but I don’t know how
> > those whitespace were introduced and how to get rid of them.
>
> Line 641, as highlighted by `git show`.
Mmm… when I apply it using b4, it doesn’t complain any more?! 🤔
```console
$ b4 shazam 20221221153230.27764-1-tanguy@bioneland.org
Looking up https://yhetil.org/guix/20221221153230.27764-1-tanguy@bioneland.org
Grabbing thread from yhetil.org/guix/20221221153230.27764-1-tanguy@bioneland.org/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Nothing matching that query.
Analyzing 10 messages in the thread
Will use the latest revision: v2
You can pick other revisions using the -vN flag
---
[PATCH v2] gnu: Add python-3.12 and python-next.
---
Total patches: 1
---
Base: using specified base-commit 6831dfc58bf14341176f7358941ed685f34fb4c3
Applying: gnu: Add python-3.12 and python-next.
```
> > Btw, the patch targets the branch `python-team`.
>
> I believe this change could target master, since it only adds python-3.12,
> but does not cause any rebuilds using it.
Oh… correct! 😅
Regards,
--
Tanguy
next prev parent reply other threads:[~2024-02-26 8:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 15:32 [bug#60240] [PATCH] [WIP] gnu: Add python-3.11 Tanguy Le Carrour
2023-01-06 17:36 ` Simon Tournier
2023-01-09 15:59 ` Tanguy LE CARROUR
2023-03-12 23:35 ` [bug#60240] Python 3.10 in core-updates Andreas Enge
2024-02-19 21:27 ` John Kehayias via Guix-patches via
2024-02-20 14:18 ` Tanguy LE CARROUR
2024-02-21 12:13 ` [bug#60240] [PATCH v2] gnu: Add python-3.12 and python-next Tanguy Le Carrour
2024-02-21 18:36 ` Tanguy Le Carrour
2024-02-22 9:07 ` Tanguy LE CARROUR
2024-02-25 14:08 ` Lars-Dominik Braun
2024-02-26 8:25 ` Tanguy LE CARROUR [this message]
2024-03-02 9:59 ` Lars-Dominik Braun
2024-03-06 12:49 ` Tanguy LE CARROUR
2024-03-06 12:55 ` [bug#60240] [PATCH v3] " Tanguy Le Carrour
2024-03-07 18:45 ` [bug#60240] [PATCH v4] " Tanguy Le Carrour
2024-03-07 18:58 ` [bug#60240] [PATCH v5] " Tanguy Le Carrour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170893592338.2024.18126018474930945065@bioneland.org \
--to=tanguy@bioneland.org \
--cc=60240@debbugs.gnu.org \
--cc=lars@6xq.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.