From: Tanguy LE CARROUR <tanguy@bioneland.org>
To: Vinicius Monego <monego@posteo.net>
Cc: 46616@debbugs.gnu.org
Subject: [bug#46616] [PATCH] gnu: Add python-tldr.
Date: Sun, 06 Jun 2021 16:14:06 +0200 [thread overview]
Message-ID: <1622988617.5jhzwoy3iq.astroid@melmoth.none> (raw)
In-Reply-To: <05b49dc60b6a7c24ffd269293b9f9536abda14f2.camel@posteo.net>
Hi Vinicius,
Thanks for reviewing this patch, and sorry for the late answer!
Excerpts from Vinicius Monego's message of May 23, 2021 11:15 pm:
> Em qui, 2021-02-18 às 15:06 +0100, Tanguy Le Carrour escreveu:
>> * gnu/packages/python-xyz.scm (python-tldr): New variable.
>> ---
>> gnu/packages/python-xyz.scm | 28 +++++++++++++++++++++++++++-
>
> [...]
>
>> +(define-public python-tldr
>> + (package
>> + (name "python-tldr")
>
> I noticed that this program is a command line tool. It should be named
> 'tldr' only and be moved to another file. Perhaps to man.scm?
Your suggestions make sense, but there's another `tldr` client.
Namely `ghc-tldr`. It's defined in `gnu/packages/haskell-xyz.scm`.
If it's okay with you, I'll leave `python-tldr` in `gnu/packages/python-xyz.scm`.
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri (pypi-uri "tldr" version))
>> + (sha256
>> + (base32
>> + "00h43xjrzrayy1gysvmql5kfabk2d8xraih68d41616brdvb1xvf"))))
>> + (build-system python-build-system)
>> + (native-inputs
>> + `(("python-pytest" ,python-pytest)
>> + ("python-pytest-runner" ,python-pytest-runner)))
>
> The tests for this one are not distributed in the PyPI release. Could
> you source from the homepage instead?
>
> There is one test that tries to open a network connection, it will have
> to be skipped.
Done.
>
>> + (propagated-inputs
>> + `(("python-argcomplete" ,python-argcomplete)
>> + ("python-colorama" ,python-colorama)
>> + ("python-termcolor" ,python-termcolor)))
>
> If it is only a command line tool, inputs should be normal inputs here.
Done.
>> + (description "This package provides the `tldr' command allowing
>> users
>> +to view `tldr' pages from a shell. The `tldr' pages are a community
>> effort
>> +to simplify the man pages with practical examples.")
>
> The linter made this complaint for the description: "use @code or
> similar ornament instead of quotes".
Done.
The new patch is following in another email…
Regards,
--
Tanguy
next prev parent reply other threads:[~2021-06-06 14:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 14:06 [bug#46616] [PATCH] gnu: Add python-tldr Tanguy Le Carrour
2021-05-23 21:15 ` Vinicius Monego
2021-06-06 14:14 ` Tanguy LE CARROUR [this message]
2021-06-06 14:16 ` [bug#46616] [PATCH v2] " Tanguy Le Carrour
2021-07-20 19:12 ` bug#46616: " Efraim Flashner
2021-07-21 6:10 ` [bug#46616] " Tanguy LE CARROUR
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1622988617.5jhzwoy3iq.astroid@melmoth.none \
--to=tanguy@bioneland.org \
--cc=46616@debbugs.gnu.org \
--cc=monego@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.