all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tanguy LE CARROUR <tanguy@bioneland.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 45158@debbugs.gnu.org
Subject: [bug#45158] [PATCH] gnu: Add python-3.9.
Date: Mon, 14 Dec 2020 09:17:35 +0100	[thread overview]
Message-ID: <1607933284.ts7cjsg6w9.astroid@rafflesia.none> (raw)
In-Reply-To: <878sa23nxb.fsf@gnu.org>

Hi Ludo’.

Excerpts from Ludovic Courtès's message of December 12, 2020 7:00 pm:
> Tanguy Le Carrour <tanguy@bioneland.org> skribis:
> 
>> * gnu/packages/python.scm (python-3.9): New variable.
>> * gnu/packages/patches/python-3.9-fix-tests.patch: New file.
> 
> Nitpick: the patch should be added to gnu/local.mk as well.

Sorry for the omission! Done.


> It LGTM but I have one concern: someone adding ‘python’ and (say)
> ‘python-itsdangerous’ to the same profile would get Python 3.9 together
> with a Python 3.8 package.  Thus ‘PYTHONPATH’ would remain unset and the
> user might become upset.  :-)
> 
> One way to work around that would be to rename 3.9 from ‘python’ to
> ‘python-next’.  That way, someone would have to explicitly install
> ‘python-next’ to get 3.9, and there wouldn’t be any bad surprises for
> the rest of us.
> 
> WDYT?

Makes total sense! I was still in the "inputs" mindset, where one has to
provide the variable name on top of the package name. But you're right,
added to a profile, it would be a mess for the `PYTHONPATH` contains a
reference to Python minor version.

As it is, the patch only applies to the `core-updates` branch, because the
file `python-3-hurd-configure.patch` only exists there. But I guess,
with the change you suggested, it can go to master. I'll also change
this in my V2.

Thanks,


-- 
Tanguy




  reply	other threads:[~2020-12-14  8:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-10 10:26 [bug#45158] [PATCH] gnu: Add python-3.9 Tanguy Le Carrour
2020-12-10 11:09 ` Tanguy LE CARROUR
2020-12-12 18:00 ` Ludovic Courtès
2020-12-14  8:17   ` Tanguy LE CARROUR [this message]
2020-12-14  8:42 ` [bug#45158] [PATCH v2] " Tanguy Le Carrour
2020-12-14 11:28   ` bug#45158: " Ludovic Courtès
2020-12-14 12:29     ` [bug#45158] " Tanguy LE CARROUR

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1607933284.ts7cjsg6w9.astroid@rafflesia.none \
    --to=tanguy@bioneland.org \
    --cc=45158@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.