From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Andrew Tropin <andrew@trop.in>
Cc: 57280@debbugs.gnu.org
Subject: [bug#57280] [PATCH 0/3] Add documentation-files argument to emacs build system.
Date: Fri, 19 Aug 2022 06:19:38 +0200 [thread overview]
Message-ID: <0f6169482efaaf9f0caac9810841e38c9c569e66.camel@gmail.com> (raw)
In-Reply-To: <87k074gb69.fsf@trop.in>
Am Freitag, dem 19.08.2022 um 06:33 +0300 schrieb Andrew Tropin:
> On 2022-08-18 20:31, Liliana Marie Prikler wrote:
> [...]
> > Am Donnerstag, dem 18.08.2022 um 17:50 +0300 schrieb Andrew Tropin:
> >
> [...]
> > > +(define (default-texinfo)
> > > + "Return the default texinfo package."
> > > + ;; Lazily resolve the binding to avoid a circular dependency.
> > > + (let ((texinfo-mod (resolve-interface '(gnu packages texinfo))))
> > > + (module-ref texinfo-mod 'texinfo)))
> > > +
> > > (define* (lower name
> > > #:key source inputs native-inputs outputs system
> > > target
> > > + documentation-files
> > I don't think hard-coding this list is useful. Instead, it would be
> > nice if we simply used find-files with the right pattern, and use a
> > binary switch as in meson-build-systems #:glib-or-gtk?
>
> It's not clear how to find a documentation file heuristically, it can
> be README, DOCUMENTATION, README.org, docs/MANUAL.org docs/PACKAGE.texi
> or anything else, morevover a few of them can be present at the same
> time and I'm afraid it will be a very tough task to understand which of
> them to use.
I think it's possible to cover most of those with heuristics. For the
rest, we can still override the phase or just rename the file to
something our heuristics handle.
> >
> > > + (texinfo (default-texinfo))
> > > (emacs (default-emacs))
> > > #:allow-other-keys
> > > #:rest arguments)
> > > @@ -77,6 +85,7 @@ (define private-keywords
> > > ;; Keep the standard inputs of 'gnu-
> > > build-
> > > system'.
> > > ,@(standard-packages)))
> > > (build-inputs `(("emacs" ,emacs)
> > > + ,@(if (null? documentation-files) '()
> > > `(("texinfo" ,texinfo)))
> > > ,@native-inputs))
> > We should probably append rather than prepend implicit inputs.
> > In fact, doing so for emacs itself also means that people could
> > prepend their own emacs if emacs-minimal is not enough rather than
> > needing a transformer.
> >
>
> I thought #:emacs and #:texinfo arguments are enough to specify
> custom emacs/texinfo inputs.
And what if any of the documentations needs emacs-org rather than the
org included by emacs-minimal? Spamming keywords is not helpful.
Cheers
> >
next prev parent reply other threads:[~2022-08-19 4:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87wnb5lhyr.fsf@trop.in>
[not found] ` <107d9c475d47842d67db4f0a7d85d63ae11f9f3c.camel@gmail.com>
2022-08-19 3:33 ` [bug#57280] [PATCH 0/3] Add documentation-files argument to emacs build system Andrew Tropin
2022-08-19 4:19 ` Liliana Marie Prikler [this message]
2022-08-19 6:21 ` Andrew Tropin
2022-08-19 15:39 ` Liliana Marie Prikler
2022-08-26 14:33 ` Andrew Tropin
2022-08-29 16:38 ` Liliana Marie Prikler
2022-08-30 8:15 ` Andrew Tropin
2022-08-30 8:28 ` Liliana Marie Prikler
2022-08-31 9:36 ` Andrew Tropin
2022-08-31 10:07 ` Liliana Marie Prikler
2022-09-02 14:02 ` Andrew Tropin
2022-09-02 14:52 ` Liliana Marie Prikler
2023-04-26 4:40 ` bug#57280: " Andrew Tropin
2022-08-18 18:35 [bug#57280] " Andrew Tropin
2022-08-18 19:31 ` Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f6169482efaaf9f0caac9810841e38c9c569e66.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=57280@debbugs.gnu.org \
--cc=andrew@trop.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.