From: Maxime Devos <maximedevos@telenet.be>
To: "Nicolò Balzarotti" <anothersms@gmail.com>, 46012@debbugs.gnu.org
Subject: [bug#46012] Acknowledgement (Upgrade Nheko)
Date: Tue, 27 Apr 2021 20:09:08 +0200 [thread overview]
Message-ID: <0d873a1e5f8db448e279d558d9f6845e161cccb7.camel@telenet.be> (raw)
In-Reply-To: <87k0onrfu7.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me>
[-- Attachment #1: Type: text/plain, Size: 2765 bytes --]
Nicolò Balzarotti schreef op di 27-04-2021 om 15:56 [+0200]:
> + (synopsis "C++ header-only HTTP/HTTPS server and client library")
> + (description "cpp-httplib is a C++11 single-file header-only cross
> +platform blocking HTTP/HTTPS library, easy to setup. Just include the
> +@file{httplib.h} file in your code!")
This is a little misleading, as shared libraries are build, as BUILD_SHARED_LIBS
is enabled. Maybe "cpp-http is a single-file header-only library" -->
"cpp-http can be used as a single-file header-only
library"?
About ‘header-only’: this is true, but ultimately irrelevant to the user
(= C++ developer on a Guix System or using Guix on top of a foreign distro).
But there's also a desirable thing called ‘portability’, the user might be
searching for a single-header web server software to distribute to other
people (not on Guix) in source form ...
I'm conflicted if "single-file header" should be included in the description.
If you decide to remove it, I suggest you add a comment like
;; this package is not graftable, as everything is implemented in a single
;; header
to prevent trouble in a (admittedly somewhat far-fetched, no insult intended
to its developers) future where cpp-httplib becomes a very popular dependency
in Guix.
> + #:phases
> + (modify-phases %standard-phases
> + (replace 'check
> + (lambda* (#:key source #:allow-other-keys)
> + ;; openssl genrsa wants to write a file in the git checkout
> + (copy-file (string-append source "/test") "test")
> + (chmod "test" #o744)
> + (invoke "make"))))))
Tests most likely should not be run when cross-compiling. I'm not 100% sure,
but you might need to do something like
> + (lambda* (#:key tests? source #:allow-other-keys)
> + ;; openssl genrsa wants to write a file in the git checkout
> + (when tests?
> + (copy-file
(string-append source "/test") "test")
> + (chmod "test" #o744)
> + (invoke "make")))))))
Search for example for "when tests?" in gnu/packages/python-xyz.scm.
> + ("zlib" ,zlib)))
In <https://github.com/yhirose/cpp-httplib/blob/master/httplib.h> I see
a few lines
#ifdef CPPHTTPLIB_ZLIB_SUPPORT
#include <zlib.h>
#endif
so it seems zlib should be in (inputs ...) instead.
I also saw these lines:
#ifdef CPPHTTPLIB_BROTLI_SUPPORT
#include <brotli/decode.h>
#include <brotli/encode.h>
#endif
Would it be useful to include brotli?
#ifdef CPPHTTPLIB_OPENSSL_SUPPORT
#include <openssl/err.h>
#include <openssl/md5.h>
...
Likewise, for openssl?
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2021-04-27 18:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 0:37 [bug#46012] Upgrade Nheko Nicolò Balzarotti
[not found] ` <handler.46012.B.161118945726837.ack@debbugs.gnu.org>
2021-01-27 23:02 ` [bug#46012] Acknowledgement (Upgrade Nheko) Nicolò Balzarotti
2021-04-27 13:56 ` Nicolò Balzarotti
2021-04-27 18:09 ` Maxime Devos [this message]
2021-04-27 21:00 ` Nicolò Balzarotti
2021-09-03 20:07 ` bug#46012: Upgrade Nheko Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d873a1e5f8db448e279d558d9f6845e161cccb7.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=46012@debbugs.gnu.org \
--cc=anothersms@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.