From: Bruno Victal <mirai@makinata.eu>
To: 62465@debbugs.gnu.org
Cc: Bruno Victal <mirai@makinata.eu>, maxim.cournoyer@gmail.com
Subject: [bug#62465] [PATCH v3 2/2] services: mcron: Add instance name support for mcron.
Date: Thu, 30 Mar 2023 15:15:19 +0100 [thread overview]
Message-ID: <090d1b4795f68fd814c89e830acbc9064bdbb648.1680185251.git.mirai@makinata.eu> (raw)
In-Reply-To: <4427884b06f47c6152b35e9559e6c1dc9412ebe5.1680185251.git.mirai@makinata.eu>
Allow running more than one mcron instance.
Make log-file a mandatory field when instantiating
mcron-configuration records.
Follow-up to <https://issues.guix.gnu.org/62169>.
* gnu/services/mcron.scm (mcron-configuration)[instance-name]: New field.
[log-file]: Update description. Remove default value.
(mcron-shepherd-services): Implement instance-name support. Set the
default service instantiation to log to /var/log/mcron.log.
* gnu/tests/base.scm (%mcron-os): Update tests.
* doc/guix.texi (Scheduled Job Execution): Update it.
---
Notable changes from v2 to v3:
Changing the final log-file value used in v2 behind the scenes
made it poorly reflexive as you couldn't trust what the accessors returned.
v3 makes log-file a mandatory field that has to be set manually and leaves
the default service instantiation responsible for setting the default log-file
that is used for the main mcron instance.
doc/guix.texi | 32 ++++++++++++++++++++++++++++++--
gnu/services/mcron.scm | 28 ++++++++++++++++++++++------
gnu/tests/base.scm | 4 +++-
3 files changed, 55 insertions(+), 9 deletions(-)
diff --git a/doc/guix.texi b/doc/guix.texi
index 5a597cf122..b9bd78f3cc 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -19383,6 +19383,10 @@ Scheduled Job Execution
This is a list of symbols naming Shepherd services that this service
will depend on.
+@item @code{instance} (type: maybe-symbol)
+Set the shepherd service name to @code{mcron-@var{instance}}. This is
+useful when you want to have more than one mcron instance.
+
@item @code{jobs} (default: @code{()}) (type: list-of-gexps)
This is a list of gexps (@pxref{G-Expressions}), where each gexp
corresponds to an mcron job specification (@pxref{Syntax, mcron job
@@ -19391,8 +19395,10 @@ Scheduled Job Execution
@item @code{log?} (default: @code{#t}) (type: boolean)
Log messages to standard output.
-@item @code{log-file} (default: @code{"/var/log/mcron.log"}) (type: string)
-Log file location.
+@item @code{log-file} (type: string)
+Log file location. By default, the main mcron instance (which is
+instantiated with @samp{(service mcron-service-type)}) is set to log to
+@file{/var/log/mcron.log}.
@item @code{log-format} (default: @code{"~1@@*~a ~a: ~a~%"}) (type: string)
@code{(ice-9 format)} format string for log messages. The default value
@@ -19407,6 +19413,28 @@ Scheduled Job Execution
@end deftp
@c %end of fragment
+Occasionally, it is desirable to run another mcron instance to separate
+some of the jobs from the main mcron instance for clarity purposes, or if
+the jobs are very chatty and frequent. (for example, a heartbeat check
+every 30 seconds)
+
+The example below shows how an extra mcron service can be defined.
+@lisp
+(use (guix)
+ (guix records)
+ (gnu services)
+ (gnu services mcron))
+
+(define secondary-mcron-service-type
+ (service-type
+ (inherit mcron-service-type)
+ (name 'mcron-secondary)
+ (default-value
+ (mcron-configuration
+ (instance 'secondary)
+ (log-file "/var/log/mcron-secondary.log")))))
+@end lisp
+
@node Log Rotation
@subsection Log Rotation
diff --git a/gnu/services/mcron.scm b/gnu/services/mcron.scm
index 99eb0edd60..164ef0e723 100644
--- a/gnu/services/mcron.scm
+++ b/gnu/services/mcron.scm
@@ -27,12 +27,14 @@ (define-module (gnu services mcron)
#:use-module (guix records)
#:use-module (guix gexp)
#:use-module (srfi srfi-1)
+ #:use-module (ice-9 format)
#:use-module (ice-9 match)
#:use-module (ice-9 vlist)
#:export (mcron-configuration
mcron-configuration?
mcron-configuration-mcron
mcron-configuration-shepherd-requirement
+ mcron-configuration-instance
mcron-configuration-jobs
mcron-configuration-log?
mcron-configuration-log-file
@@ -63,6 +65,7 @@ (define list-of-symbols?
(list-of symbol?))
(define-maybe/no-serialization string)
+(define-maybe/no-serialization symbol)
(define-configuration/no-serialization mcron-configuration
(mcron
@@ -74,6 +77,11 @@ (define-configuration/no-serialization mcron-configuration
"This is a list of symbols naming Shepherd services that this service
will depend on.")
+ (instance
+ maybe-symbol
+ "Set the shepherd service name to @code{mcron-@var{instance}}.
+This is useful when you want to have more than one mcron instance.")
+
(jobs
(list-of-gexps '())
"This is a list of gexps (@pxref{G-Expressions}), where each gexp
@@ -85,8 +93,10 @@ (define-configuration/no-serialization mcron-configuration
"Log messages to standard output.")
(log-file
- (string "/var/log/mcron.log")
- "Log file location.")
+ string
+ "Log file location. By default, the main mcron instance
+(which is instantiated with @samp{(service mcron-service-type)})
+is set to log to @file{/var/log/mcron.log}.")
(log-format
(string "~1@*~a ~a: ~a~%")
@@ -167,12 +177,16 @@ (define (shepherd-schedule-action mcron files)
(define (mcron-shepherd-services config)
(match-record config <mcron-configuration>
- (mcron shepherd-requirement jobs log? log-file log-format date-format)
+ (mcron shepherd-requirement instance
+ jobs log? log-file log-format date-format)
(if (eq? jobs '())
'() ;nothing to do
- (let ((files (job-files mcron jobs)))
+ (let* ((files (job-files mcron jobs))
+ (instance-name
+ (format #f "mcron~@[-~a~]" (maybe-value instance)))
+ (service-name (string->symbol instance-name)))
(list (shepherd-service
- (provision '(mcron))
+ (provision (list service-name))
(requirement `(user-processes ,@shepherd-requirement))
(modules `((srfi srfi-1)
(srfi srfi-26)
@@ -220,7 +234,9 @@ (define mcron-service-type
(inherit config)
(jobs (append (mcron-configuration-jobs config)
jobs)))))
- (default-value (mcron-configuration)))) ;empty job list
+ (default-value
+ (mcron-configuration
+ (log-file "/var/log/mcron.log"))))) ;empty job list
\f
;;;
diff --git a/gnu/tests/base.scm b/gnu/tests/base.scm
index 97edbbc6ad..ffff713e4c 100644
--- a/gnu/tests/base.scm
+++ b/gnu/tests/base.scm
@@ -885,7 +885,9 @@ (define %mcron-os
"touch witness-touch")))
(simple-operating-system
(service mcron-service-type
- (mcron-configuration (jobs (list job1 job2 job3)))))))
+ (mcron-configuration
+ (jobs (list job1 job2 job3))
+ (log-file "/var/log/mcron.log"))))))
(define (run-mcron-test name)
(define os
--
2.39.1
next prev parent reply other threads:[~2023-03-30 14:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-26 18:18 [bug#62465] [PATCH] services: mcron: Add instance name support for mcron Bruno Victal
2023-03-29 13:44 ` [bug#62465] [PATCH v2 1/2] services: mcron: Add 'shepherd-requirement' field Bruno Victal
2023-03-29 13:54 ` [bug#62465] [PATCH v2 2/2] services: mcron: Add instance name support for mcron Bruno Victal
2023-03-30 14:15 ` [bug#62465] [PATCH v3 1/2] services: mcron: Add 'shepherd-requirement' field Bruno Victal
2023-03-30 14:15 ` Bruno Victal [this message]
2023-04-01 17:35 ` [bug#62465] [PATCH v4 1/3] " Bruno Victal
2023-04-01 17:35 ` [bug#62465] [PATCH v4 2/3] services: mcron: Add instance name support for mcron Bruno Victal
2023-04-01 17:35 ` [bug#62465] [PATCH v4 3/3] services: mcron: Add user-name, user-group and supplementary-groups fields Bruno Victal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=090d1b4795f68fd814c89e830acbc9064bdbb648.1680185251.git.mirai@makinata.eu \
--to=mirai@makinata.eu \
--cc=62465@debbugs.gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.