From: Tobias Geerinckx-Rice <me@tobias.gr>
To: boskovits@gmail.com, 29891@debbugs.gnu.org
Subject: [bug#29891] [PATCH] gnu: java-classpathx-servletapi: Update to 3.0-r1244.
Date: Sun, 14 Jan 2018 16:04:42 +0100 [thread overview]
Message-ID: <052c85c4-0370-35d3-17dd-66d5f2667592@tobias.gr> (raw)
In-Reply-To: <CAE4v=phyc2osUtk5-+oHVeJ0+p3fo0FQ6oA+=-jyyBLg2OryOg@mail.gmail.com>
Gábor,
Gábor Boskovits wrote on 09/01/18 at 11:56:
> Reworded commit message.
Sorry to be a drive-by nit-picker, but this commit message is still much
longer than needed:
> 2018-01-09 11:55 GMT+01:00 Gábor Boskovits <boskovits@gmail.com
> <mailto:boskovits@gmail.com>>:
>
> * gnu/packages/java.scm (java-classpathx-servletapi): Update to
> 3.0-r1244.
> [source]: Change to svn-fetch from upstream. (This version is only
> available from there)
That parenthesis should be far more useful to future generations as a
comment in the code.
> [arguments]: Switch to a java8 compiler, remove comment about not
> working with java8,
The first half implies the second: I'd not mention the comment.
> add phase chdir to compensate for the different layout of the
> upstream repository.
Also very verbose (just “Add ‘chdir’ phase.”?) but OK :-)
Kind regards,
T G-R
next prev parent reply other threads:[~2018-01-14 15:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-29 13:41 [bug#29891] [PATCH core-updates] gnu: java-classpathx-servletapi: Update to 3.0-r1244 Gábor Boskovits
2018-01-07 22:11 ` [bug#29891] [PATCH] " Gábor Boskovits
2018-01-07 22:13 ` Gábor Boskovits
2018-01-09 7:25 ` Chris Marusich
2018-01-09 9:59 ` Gábor Boskovits
2018-01-09 10:55 ` Gábor Boskovits
2018-01-09 10:56 ` Gábor Boskovits
2018-01-14 2:25 ` Chris Marusich
2018-01-14 9:07 ` Gábor Boskovits
2018-01-14 15:04 ` Tobias Geerinckx-Rice [this message]
2018-01-14 15:28 ` Gábor Boskovits
2018-01-15 8:27 ` [bug#29891] [PATCH] gnu: java-classpathx-servletapi: Update to 3.0.1 Gábor Boskovits
2018-01-16 8:03 ` bug#29891: " Chris Marusich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=052c85c4-0370-35d3-17dd-66d5f2667592@tobias.gr \
--to=me@tobias.gr \
--cc=29891@debbugs.gnu.org \
--cc=boskovits@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.