From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Gabriel Wicki <gabriel@erlikon.ch>
Cc: 63071@debbugs.gnu.org, andrew@trop.in
Subject: [bug#63071] [PATCH] gnu: Add emacs-riscv-mode
Date: Tue, 25 Apr 2023 21:07:22 +0200 [thread overview]
Message-ID: <038cfa65746b53fd739bbbb2920064391e625ffe.camel@gmail.com> (raw)
In-Reply-To: <20230425182713.hcbaj2vqa5vzce7s@blackbox>
On Tue, 2023-04-25 at 20:27 +0200, Gabriel Wicki wrote:
> On Tue, Apr 25, 2023 at 08:21:11PM +0200, Liliana Marie Prikler
> wrote:
> > No need to let-bind url and version, please use their values in the
> > right locations below.
> I thought I'd bind them since the values were used multiple times.
>
> Anyhow, I've corrected the patch. Thank you for that super-quick
> reply!
>
>
> From ed779ffef71167d18256a21dbcab99d27c3a5176 Mon Sep 17 00:00:00
> 2001
> Message-Id:
> <ed779ffef71167d18256a21dbcab99d27c3a5176.1682447183.git.gabriel@erli
> kon.ch>
> From: Gabriel Wicki <gabriel@erlikon.ch>
> Date: Tue, 25 Apr 2023 17:48:41 +0200
> Subject: [PATCH] gnu: Add emacs-riscv-mode.
>
> * gnu/packages/emacs-xyz.scm (emacs-riscv-mode): New variable.
> ---
> gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 7c8af093fc..33c745d029 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -35854,6 +35854,30 @@ (define-public emacs-nasm-mode
> Unlike Emacs' generic ASM mode, it understands NASM-specific
> syntax.")
> (license license:unlicense)))
>
> +(define-public emacs-riscv-mode
> + (let ((commit "8e335b9c93de93ed8dd063d702b0f5ad48eef6d7")
> + (revision "1"))
> + (package
> + (name "emacs-riscv-mode")
> + (version (git-version "0" revision commit))
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url
> "https://github.com/AdamNiederer/riscv-mode")
> + (commit commit)))
> + (file-name (git-file-name name "0"))
Use "version" here. It won't refer to "0", but instead to the expanded
(git-version ...) -- it's basically syntactic sugar for (package-
version this-package).
> + (sha256
> + (base32
> +
> "06jlf84mx49scw3zm1wjj25zinr2yr9abiyh83rli78wb1hdc0l4"))))
> + (build-system emacs-build-system)
> + (home-page "https://github.com/AdamNiederer/riscv-mode")
> + (synopsis "Emacs major mode for RISC-V assembly")
> + (description
> + "RISC-V mode is a major mode for editing RISC-V assembly
> programs.
> +It includes syntax highlighting, syntactic indentation and code
> evaluation
> +with spike.")
> + (license license:gpl3))))
License should be gpl3+ going by the README.
Cheers
next prev parent reply other threads:[~2023-04-25 19:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 17:23 [bug#63071] [PATCH] gnu: Add emacs-riscv-mode Gabriel Wicki
2023-04-25 15:48 ` Gabriel Wicki
2023-04-26 4:29 ` Andrew Tropin
2023-05-03 12:28 ` bug#63071: " Nicolas Goaziou
2023-04-25 18:21 ` [bug#63071] " Liliana Marie Prikler
2023-04-25 18:27 ` Gabriel Wicki
2023-04-25 19:07 ` Liliana Marie Prikler [this message]
2023-04-25 19:14 ` Gabriel Wicki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=038cfa65746b53fd739bbbb2920064391e625ffe.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=63071@debbugs.gnu.org \
--cc=andrew@trop.in \
--cc=gabriel@erlikon.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.