From: Maxime Devos <maximedevos@telenet.be>
To: Sarah Morgensen <iskarian@mgsn.dev>, 50363@debbugs.gnu.org
Subject: [bug#50363] [PATCH v2] Improve default diff hunk header detection.
Date: Fri, 10 Sep 2021 19:07:44 +0200 [thread overview]
Message-ID: <02da42c122f4fe839e12a3c8688cc49b140fcb12.camel@telenet.be> (raw)
In-Reply-To: <e6e08312afa17ee812f8b538118bec6da86d3357.1630708121.git.iskarian@mgsn.dev>
[-- Attachment #1: Type: text/plain, Size: 1226 bytes --]
Sarah Morgensen schreef op vr 03-09-2021 om 15:39 [-0700]:
> Tell git to look for top-level definitions for diff hunk headers in
> Scheme files.
>
> .gitattributes: New file.
> .gitconfig: New file.
> ---
> Hello Guix,
>
> This patch improves the diff hunk headers for diffs on scheme files in this
> repository. These settings are always settable (and overridable) on a
> per-user basis, but I think having them as defaults is nice.
>
> This may help with patches applying in general, but the main goal is to make
> etc/committer.scm a little less brittle.
>
> The default "scheme" function regex (enabled with .gitattributes) recognizes
> both toplevel and non-toplevel defines. I've modified the regex in .gitconfig
> to only recognize the toplevel defines. I think this makes more sense for our
> purposes.
>
> Unfortunately, checked-in git config settings cannot be automatically used
> (for security reasons), and must be enabled with a once-per-clone
>
> git config --local include.path ../.gitconfig
>
> which isn't ideal. I suppose we could make a 'make' target for setup like
> this if we wanted to make it easy.
>
> WDYT?
This seems nice to me.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2021-09-10 17:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 22:39 [bug#50363] [PATCH v2] Improve default diff hunk header detection Sarah Morgensen
2021-09-10 17:07 ` Maxime Devos [this message]
2021-09-13 10:24 ` [bug#50363] [PATCH] " Ludovic Courtès
2021-09-19 18:36 ` [bug#50363] [PATCH v3] " Sarah Morgensen
2021-09-19 22:09 ` Kyle Meyer
2021-09-19 22:56 ` Sarah Morgensen
2021-09-20 0:57 ` Kyle Meyer
2021-09-20 23:37 ` [bug#50363] [PATCH v4] " Sarah Morgensen
2021-09-22 12:55 ` Ludovic Courtès
2021-09-22 16:22 ` Sarah Morgensen
2021-10-04 12:26 ` bug#50363: [PATCH] " Ludovic Courtès
2021-10-13 22:30 ` [bug#50363] " Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02da42c122f4fe839e12a3c8688cc49b140fcb12.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=50363@debbugs.gnu.org \
--cc=iskarian@mgsn.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.