From: Maxime Devos <maximedevos@telenet.be>
To: Gabriel Wicki <gabriel@erlikon.ch>, 57291@debbugs.gnu.org
Subject: [bug#57291] New package: fftgen
Date: Fri, 2 Sep 2022 20:57:59 +0200 [thread overview]
Message-ID: <00f0e2ce-7286-6be8-d807-15703fe9778a@telenet.be> (raw)
In-Reply-To: <20220818231841.vncyowy57s2awb74@silvi>
[-- Attachment #1.1.1: Type: text/plain, Size: 716 bytes --]
On 19-08-2022 01:18, Gabriel Wicki wrote:
> + (file-name (git-file-name name
> + (string-take commit 8)))
You don't have to string-take, the standard pattern is (git-file-name
name version), as in (guix)Version Numbers.
> + `(#:tests? #f
Why are tests disabled? There is a bench-test target, maybe you need
#:test-target "bench-test"? I hope that means "test bench" and not
"benchmark" though.
On the license: some parts are GPL3+ (see:
https://github.com/ZipCPU/dblclockfft/blob/master/sw/legal.h), that
sounds important to add to the license field to me (license
(license:lgpl3+ license:gpl3+)).
Greetings,
Maxime.
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
prev parent reply other threads:[~2022-09-02 18:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 23:18 [bug#57291] New package: fftgen Gabriel Wicki
2022-09-02 15:29 ` bug#57291: " Ludovic Courtès
2022-09-02 19:00 ` [bug#57291] " Maxime Devos
2022-09-02 18:57 ` Maxime Devos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00f0e2ce-7286-6be8-d807-15703fe9778a@telenet.be \
--to=maximedevos@telenet.be \
--cc=57291@debbugs.gnu.org \
--cc=gabriel@erlikon.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.