From: Julien Lepiller <julien@lepiller.eu>
To: Prafulla Giri <pratheblackdiamond@gmail.com>,42960@debbugs.gnu.org
Subject: [bug#42960] Add New Package: ronn-ng
Date: Thu, 20 Aug 2020 13:10:12 -0400 [thread overview]
Message-ID: <00BA282B-61E0-4B85-9248-AE6432E0BF77@lepiller.eu> (raw)
In-Reply-To: <CAFw+=j2jM3xGsKPfzB2DE9Qq8P3q1P4dC-WfY09uBqTe_eedzQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 958 bytes --]
So I can't try your patch right now, nor cite it in my answer to show you, sorry.
From what I see, here are a few comments. Can you fix them and send us an updated patch? I'll push as soon as I'm back home this evening.
You should add a copyright line for yourself (unless you already have one, I haven't checked the existing file).
The rest is related to whitespace and so. You shouldn't use a newline right after add-after. Look at other packages to see how it's done. You've left a (begin …) that you probably used for debugging. There's a space in the closing parenthesis at the end of tge arguments. The discripcion is weirdly formatted: use two spaces after the period, and continue on the same line, breaking just before 80 characters.
Thank you!
On 2020年8月20日 11:50:31 GMT-04:00, Prafulla Giri <pratheblackdiamond@gmail.com> wrote:
>Esteemed Maintainers,
>
>Attached patch contains a definition of ronn-ng.
>
>Thank you!
[-- Attachment #2: Type: text/html, Size: 1271 bytes --]
next prev parent reply other threads:[~2020-08-20 17:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 15:50 [bug#42960] Add New Package: ronn-ng Prafulla Giri
2020-08-20 17:10 ` Julien Lepiller [this message]
2020-08-21 2:28 ` Prafulla Giri
2020-08-21 12:36 ` bug#42960: " Julien Lepiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00BA282B-61E0-4B85-9248-AE6432E0BF77@lepiller.eu \
--to=julien@lepiller.eu \
--cc=42960@debbugs.gnu.org \
--cc=pratheblackdiamond@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.