all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: <db@minikn.xyz>
To: <51779@debbugs.gnu.org>
Subject: [bug#51779] [PATCH] Add phonesim 1.21
Date: Fri, 12 Nov 2021 20:19:03 +0100	[thread overview]
Message-ID: <006401d7d7fa$27f236e0$77d6a4a0$@minikn.xyz> (raw)
In-Reply-To: <20211111221457.6025-1-db@minikn.xyz>

Hello Tobias,

thank you for your input. This is my first attempt at submitting a patch
through a mailing list. I expected some mistakes. On top of that, my
guile is bad as well (I'm just starting with it).

> Check the git log for commits adding new packages for the expected
> 'change-log-style' commit message.

Thanks. I think it should have been `[PATCH] gnu: Add phonesim'. How can
I change that?

> This is unusual enough to require a comment explaining why it's here.

The short answer is - I don't know. I copied it from the source:

https://git.kernel.org/pub/scm/network/ofono/phonesim.git/tree/bootstrap-con
figure

I should also mention that I do not have any experience with the
application. I never used it nor do I really understand what it does. I
just submitted a patch because it is part of what needs to be done in
order to get bluetooth headsets fully working in Guix (with microphone),
see

https://wiki.archlinux.org/title/Bluetooth_headset#HFP_not_working_with_Puls
eAudio

This is beside the point, but I'm mentioning it to give a little
background why I may not be able to give insight on why things are done
a certain way.

That being said, here is the new patch version:

---
 gnu/packages/telephony.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
index a2765ee99f..6e3c69ce91 100644
--- a/gnu/packages/telephony.scm
+++ b/gnu/packages/telephony.scm
@@ -20,6 +20,7 @@
 ;;; Copyright C 2020, 2021 Maxim Cournoyer <maxim.cournoyer@gmail.com>
 ;;; Copyright C 2020 Vincent Legoll <vincent.legoll@gmail.com>
 ;;; Copyright C 2021 LibreMiami <packaging-guix@libremiami.org>
+;;; Copyright C 2021 Demis Balbach <db@minikn.xyz>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -87,6 +88,7 @@ (define-module (gnu packages telephony)
   #:use-module (gnu packages bison)
   #:use-module (gnu packages flex)
   #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix utils)
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix git-download)
@@ -94,6 +96,37 @@ (define-module (gnu packages telephony)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system qt))

+(define-public phonesim
+  (package
+    (name "phonesim")
+    (version "1.21")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url
"https://git.kernel.org/pub/scm/network/ofono/phonesim.git")
+                    (commit "a7c844d45b047b2dae5b0877816c346fce4c47b9")))
+              (sha256
+               (base32
+                "0rc1c2vr03dmi1dr3skj57v77ga9c22g29xs1qiphqms4isby9cq"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags
+       (list "--enable-maintainer-mode"
+             "CC=" ,(cc-for-target))))
+    (native-inputs
+     `(("automake" ,automake)
+       ("autoconf" ,autoconf)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("qtbase" ,qtbase-5)
+       ("qtdeclarative" ,qtdeclarative)))
+    (synopsis "Phone Simulator for modem testing")
+    (description "Phonesim is a modem emulator that oFono uses for
development
+and testing. This allows oFono to be used by any host without requiring
special
+GSM (or other) hardware.")
+    (home-page "https://git.kernel.org/pub/scm/network/ofono/phonesim.git")
+    (license license:gpl2+)))
+
 (define-public libilbc
   (package
     (name "libilbc")
--
2.33.0

Greetings,

Demis.





  parent reply	other threads:[~2021-11-12 19:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-11 22:14 [bug#51779] [PATCH] Add phonesim 1.21 Demis Balbach
2021-11-12 15:05 ` Tobias Geerinckx-Rice via Guix-patches via
2021-11-12 19:19 ` db [this message]
2021-11-13 10:01   ` Josselin Poiret via Guix-patches via
2021-11-23 18:37 ` Demis Balbach
2021-11-23 18:55 ` Demis Balbach
2021-12-05 20:57   ` bug#51779: " Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='006401d7d7fa$27f236e0$77d6a4a0$@minikn.xyz' \
    --to=db@minikn.xyz \
    --cc=51779@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.