all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Remco van 't Veer <remco@remworks.net>, 55516@debbugs.gnu.org
Cc: liliana.prikler@ist.tugraz.at, ludo@gnu.org, jaft.r@outlook.com
Subject: [bug#55516] [PATCH v2] gnu: Add quodlibet.
Date: Sat, 28 May 2022 14:36:35 +0200	[thread overview]
Message-ID: <00334395f86760c290306e3801a9bfa38f63734e.camel@telenet.be> (raw)
In-Reply-To: <20220528085718.27307-1-remco@remworks.net>

[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]

Remco van 't Veer schreef op za 28-05-2022 om 10:57 [+0200]:
> [...]
> +         (add-after 'install 'wrap-gi-typelib ; GObject Introspection
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((out (assoc-ref outputs "out"))
> +                   (gi-typelib-path (getenv "GI_TYPELIB_PATH")))
> +               (for-each (lambda (prog)
> +                           (wrap-program (string-append out "/bin/" prog)
> +                             `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path))))
> +                         '("exfalso" "quodlibet")))
> [...]
> +
> +    (native-inputs [...])
> +    (inputs [...])

bash-minimal (which is required when wrap-program is used for cross-
compilation reasons) is missing from inputs.  For future reference,
this issue would be detected by "guix lint".  There were some other
suboptimalities too (trailing #t, unconditional #:tests? #true), but
they have been corrected by Liliana in
<https://git.savannah.gnu.org/cgit/guix.git/commit/?id=092ec158f73b0f4a4817517149e4cb49b2d8e490>

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

      parent reply	other threads:[~2022-05-28 12:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-19  4:41 [bug#55516] [PATCH] gnu: Add quod-libet Wamm K. D
2022-05-19  6:15 ` Liliana Marie Prikler
2022-05-19  7:49   ` Jaft
2022-05-19  7:58     ` Liliana Marie Prikler
2022-05-22  1:27       ` Jaft
2022-05-21 14:45 ` Remco van 't Veer
2022-05-21 14:48   ` [bug#55516] [PATCH] gnu: Add quodlibet Remco van 't Veer
2022-05-27 21:54   ` [bug#55516] [PATCH] gnu: Add quod-libet Ludovic Courtès
2022-05-28  8:55     ` Remco van 't Veer
2022-05-30  2:06       ` Wamm K. D.
2022-05-28  8:57     ` [bug#55516] [PATCH v2] gnu: Add quodlibet Remco van 't Veer
2022-05-28 11:13       ` bug#55516: " Liliana Marie Prikler
2022-05-28 12:36       ` Maxime Devos [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00334395f86760c290306e3801a9bfa38f63734e.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=55516@debbugs.gnu.org \
    --cc=jaft.r@outlook.com \
    --cc=liliana.prikler@ist.tugraz.at \
    --cc=ludo@gnu.org \
    --cc=remco@remworks.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.