From: "Todor Kondić" <tk.code@protonmail.com>
To: "35810@debbugs.gnu.org" <35810@debbugs.gnu.org>
Subject: [bug#35810] [PATCH] Add RMassBank (r-massbank)
Date: Sat, 25 May 2019 14:00:51 +0000 [thread overview]
Message-ID: <-cy39DznjGBQcCG_dhZ4VVA498WC4pj16AS9vrtFjwTeRK3qV6vBpnLUiL_EyW9yKy2jD3XZCXK-gtpkyXYKJCnP2nJaoS4qxrBPZ6pov-s=@protonmail.com> (raw)
In-Reply-To: <874l5ju9mb.fsf@gnu.org>
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Friday, 24 May 2019 17:59, Ludovic Courtès <ludo@gnu.org> wrote:
> Hello Todor,
>
> Tk tk.code@protonmail.com skribis:
>
> > Some of us at ECI (Environmental Cheminformatics), LCSB, University of Luxembourg
> > are in love with Scheme, GNU, Guile and Guix.
>
> Heh, cool. :-)
>
> > At ECI, there is a lot of mass spectrometry going on and there are plenty of
> > R tools -- some written by us -- to analyse and annotate such spectra. Anyway,
> > this is our first contribution to Guix -- RMassBank (r-massbank package).
> > I have decided to create a separate package group for mass-spectrometry and
> > include r-massbank in it. I could imagine packages defined here to end up in
> > chemistry.scm, or under a new subpath, chemistry/mass-spectrometry.scm. Once
> > this first submission enters Guix, some more will follow.
> > The packages themselves have been generated using
> > `guix import cran -r --archive=bioconductor RMassBank` and minimally altered
> > to build successfully and not bother guix lint too much.
>
> Looks good to me. Ricardo, WDYT?
>
> > As this is my first contribution to guix, I am very much looking forward
> > to feedback.
>
> The file is OK as-is, but could you send directly the output of ‘git
> format-patch’? That makes it easier for us to apply the patch while
> preserving authorship information.
>
> Also, bonus points if you can come up with a commit log that follows our
> conventions. :-)
>
> https://www.gnu.org/software/guix/manual/en/html_node/Submitting-Patches.html
>
> Anyway, glad to see more scientists join! You might be interested in
> https://guix-hpc.bordeaux.inria.fr/ too.
>
> Welcome!
>
> Thanks,
> Ludo’.
Hi Ludo’,
Thanks for the words of welcome :) . Actually, I have been lurking in shadows for a long time, probably from the time you first announced Guix on the guile list. It grew a lot since those days.
My previous reply is, hopefully, sorting things out re mass spectrometry and rmassbank. I haven't yet set my new work machine with a proper email and have to resort to webmail (which sucks).
Cheers,
Todor
next prev parent reply other threads:[~2019-05-25 15:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 14:20 [bug#35810] [PATCH] Add RMassBank (r-massbank) Tk
2019-05-24 15:59 ` Ludovic Courtès
2019-05-25 14:00 ` Todor Kondić [this message]
2019-05-28 22:16 ` Ricardo Wurmus
2019-05-25 13:41 ` Todor Kondić
2019-07-07 7:06 ` [bug#35810] [PATCH] Add RMassBank (r-massbank) [CLOSING THIS ONE] Todor Kondić
2020-08-04 13:55 ` bug#35810: Closing [PATCH] Add RMassBank (r-massbank) Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='-cy39DznjGBQcCG_dhZ4VVA498WC4pj16AS9vrtFjwTeRK3qV6vBpnLUiL_EyW9yKy2jD3XZCXK-gtpkyXYKJCnP2nJaoS4qxrBPZ6pov-s=@protonmail.com' \
--to=tk.code@protonmail.com \
--cc=35810@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.